Skip to content

Commit 7d0c943

Browse files
sjuddConvex, Inc.
authored andcommitted
Cleanup old udf limits (#24112)
GitOrigin-RevId: 13f31535606332d78a025edc31a91ab446f1f3b9
1 parent dde0613 commit 7d0c943

File tree

1 file changed

+3
-21
lines changed

1 file changed

+3
-21
lines changed

crates/common/src/knobs.rs

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -617,16 +617,8 @@ pub static APPLICATION_MAX_CONCURRENT_MUTATIONS: LazyLock<usize> =
617617
/// knob.
618618
///
619619
/// The value here may be overridden by big brain.
620-
pub static APPLICATION_MAX_CONCURRENT_V8_ACTIONS: LazyLock<usize> = LazyLock::new(|| {
621-
env_config(
622-
"APPLICATION_MAX_CONCURRENT_V8_ACTIONS",
623-
*APPLICATION_MAX_CONCURRENT_ACTIONS,
624-
)
625-
});
626-
// TODO(CX-6067): Remove APPLICATION_MAX_CONCURRENT_ACTIONS and merge the
627-
// default into *_V8_ACTIONS
628-
static APPLICATION_MAX_CONCURRENT_ACTIONS: LazyLock<usize> =
629-
LazyLock::new(|| env_config("APPLICATION_MAX_CONCURRENT_ACTIONS", 16));
620+
pub static APPLICATION_MAX_CONCURRENT_V8_ACTIONS: LazyLock<usize> =
621+
LazyLock::new(|| env_config("APPLICATION_MAX_CONCURRENT_V8_ACTIONS", 16));
630622

631623
/// The maximum number of node actions that can be run concurrently by an
632624
/// application
@@ -637,9 +629,8 @@ static APPLICATION_MAX_CONCURRENT_ACTIONS: LazyLock<usize> =
637629
/// limit, we'll see 429 error responses for node actions.
638630
///
639631
/// The value here may be overridden by big brain.
640-
// TODO(CX-6067): Reduce this back down to 16.
641632
pub static APPLICATION_MAX_CONCURRENT_NODE_ACTIONS: LazyLock<usize> =
642-
LazyLock::new(|| env_config("APPLICATION_MAX_CONCURRENT_NODE_ACTIONS", 1000));
633+
LazyLock::new(|| env_config("APPLICATION_MAX_CONCURRENT_NODE_ACTIONS", 16));
643634

644635
/// Number of threads to execute V8 actions.
645636
///
@@ -651,15 +642,6 @@ pub static APPLICATION_MAX_CONCURRENT_NODE_ACTIONS: LazyLock<usize> =
651642
pub static APPLICATION_MAX_CONCURRENT_HTTP_ACTIONS: LazyLock<usize> = LazyLock::new(|| {
652643
env_config(
653644
"APPLICATION_MAX_CONCURRENT_HTTP_ACTIONS",
654-
*V8_ACTION_MAX_ISOLATE_EXEC_THREADS,
655-
)
656-
});
657-
658-
// TODO(CX-6067): Remove V8_ACTION_MAX_ISOLATE_EXEC_THREADS and merge the
659-
// default into *_HTTP_ACTIONS
660-
static V8_ACTION_MAX_ISOLATE_EXEC_THREADS: LazyLock<usize> = LazyLock::new(|| {
661-
env_config(
662-
"V8_ACTION_MAX_ISOLATE_EXEC_THREADS",
663645
if cfg!(any(test, feature = "testing")) {
664646
2
665647
} else {

0 commit comments

Comments
 (0)