Fix searchlight running locally by creating directory if doesn't exist (#26892)

Make it easier to debug archive cache and fix bug where extracting archive onto disk would fail if the directory did not exist.

GitOrigin-RevId: 3adc4ee12dd9e19d6152f7fa271a2596ae816954

Author: emmaling27

crates/async_lru/src/async_lru.rs

@@ -185,6 +185,16 @@ enum Status<Value> {
     ),
 }
 
+impl<Value> std::fmt::Display for Status<Value> {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        match self {
+            Status::Ready(_) => write!(f, "Ready"),
+            Status::Waiting(_) => write!(f, "Waiting"),
+            Status::Kickoff(..) => write!(f, "Kickoff"),
+        }
+    }
+}
+
 impl<
         RT: Runtime,
         Key: Hash + Eq + Debug + Clone + Send + Sync + 'static,
@@ -370,7 +380,9 @@ impl<
         key: &Key,
         value_generator: ValueGenerator<Key, Value>,
     ) -> anyhow::Result<Arc<Value>> {
-        match self.get_sync(key, value_generator)? {
+        let status = self.get_sync(key, value_generator)?;
+        tracing::debug!("Getting key {key:?} with status {status}");
+        match status {
             Status::Ready(value) => Ok(value),
             Status::Waiting(rx) => Ok(Self::wait_for_value(key, rx).await?),
             Status::Kickoff(rx, timer) => {

crates/search/src/archive/cache.rs

@@ -379,10 +379,13 @@ impl<RT: Runtime> ArchiveCacheManager<RT> {
             .get(
                 cache_key.clone(),
                 archive_fetcher
-                    .generate_value(search_storage, key.clone(), search_file_type)
+                    .generate_value(search_storage.clone(), key.clone(), search_file_type)
                     .boxed(),
             )
-            .await?;
+            .await
+            .with_context(|| {
+                format!("Failed to get cache_key {cache_key:?} in {search_storage:?}")
+            })?;
 
         let path = result.path.clone();
         let current_size = self.cache.size();

crates/search/src/archive/mod.rs

@@ -18,15 +18,15 @@ use tokio::io::AsyncRead;
 pub mod cache;
 mod metrics;
 
-/// Extract the archive stream to the specified output directory, which must not
-/// exist or this method will return an Error. This function should only be used
+/// Extract the archive stream to the specified output directory, which will be
+/// created if it doesn't already exist. This function should only be used
 /// for trusted ZIP archives; we don't make any attempt to guard against
 /// directory traversal attacks nor do we sanitize paths.
 pub(crate) async fn extract_zip<P: AsRef<Path>>(
     output_directory: P,
     archive: impl AsyncRead,
 ) -> anyhow::Result<u64> {
-    std::fs::create_dir(&output_directory)?;
+    std::fs::create_dir_all(&output_directory)?;
     pin_mut!(archive);
     let mut reader = ZipFileReader::new(archive);
     let mut created_paths: HashSet<PathBuf> = HashSet::new();