Remove more unnecessary infallible conversions (#24710)

GitOrigin-RevId: d1465416c8628d01e7247f6c1783959faf1c1a0d

Author: sjudd

crates/application/src/export_worker.rs

@@ -1192,7 +1192,7 @@ mod tests {
         let document = ResolvedDocument::new(
             ResolvedDocumentId::min(),
             (1234.0).try_into()?,
-            ConvexObject::for_value("a".parse()?, 33.try_into()?)?,
+            ConvexObject::for_value("a".parse()?, 33.into())?,
         )?;
         let table_upload = table_upload.write(document).await?;
         let key = table_upload.complete().await?;
@@ -1222,7 +1222,7 @@ mod tests {
         let document = ResolvedDocument::new(
             ResolvedDocumentId::min(),
             (1234.0).try_into()?,
-            ConvexObject::for_value("a".parse()?, 33.try_into()?)?,
+            ConvexObject::for_value("a".parse()?, 33.into())?,
         )?;
         let table_upload = table_upload.write(document.clone()).await?;
         let table_upload = table_upload.write(document).await?;

crates/common/src/bootstrap_model/index/vector_index/segment.rs

@@ -114,18 +114,16 @@ impl FragmentedVectorSegment {
     }
 }
 
-impl TryFrom<FragmentedVectorSegment> for pb::searchlight::FragmentedVectorSegment {
-    type Error = anyhow::Error;
-
-    fn try_from(value: FragmentedVectorSegment) -> Result<Self, Self::Error> {
-        Ok(Self {
+impl From<FragmentedVectorSegment> for pb::searchlight::FragmentedVectorSegment {
+    fn from(value: FragmentedVectorSegment) -> Self {
+        Self {
             segment_key: value.segment_key.into(),
             id_tracker_key: value.id_tracker_key.into(),
             deleted_bitset_key: value.deleted_bitset_key.into(),
             num_vectors: value.num_vectors,
             num_deleted: value.num_deleted,
             id: value.id,
-        })
+        }
     }
 }
 

crates/local_backend/src/parse.rs

@@ -58,7 +58,7 @@ mod tests {
         let mut id_generator = TestIdGenerator::new();
 
         let id_v5 = id_generator.generate(&ENVIRONMENT_VARIABLES_TABLE);
-        let id_v6: DocumentIdV6 = id_v5.try_into()?;
+        let id_v6: DocumentIdV6 = id_v5.into();
 
         let table_mapping = id_generator.clone();
         let id_v6_string = id_v6.encode();