private-demos/tanstack-start: Migrate ESLint to v9 (#42398)

GitOrigin-RevId: f2620c2ff8b65df63759a4ad89e93f2c9127f364

Author: Nicolapps

npm-packages/common/config/rush/pnpm-lock.yaml

@@ -4,3 +4,4 @@
 pnpm-lock.yaml
 routeTree.gen.ts
 convex/_generated/*
+dist/*

npm-packages/private-demos/tanstack-start/.eslintrc

@@ -1,33 +1,44 @@
-import { action, mutation } from './_generated/server'
-import { query } from './_generated/server'
-import { api } from './_generated/api.js'
 import { v } from 'convex/values'
+import { action, mutation, query } from './_generated/server'
+import { api } from './_generated/api.js'
 
-export const list = query(async (ctx, { cacheBust }) => {
-  const _unused = cacheBust
-  return await ctx.db.query('messages').collect()
+export const list = query({
+  args: {},
+  handler: async (ctx) => {
+    return await ctx.db.query('messages').collect()
+  },
 })
 
-export const count = query(async (ctx, { cacheBust }) => {
-  const _unused = cacheBust
-  return (await ctx.db.query('messages').collect()).length
+export const count = query({
+  args: {
+    cacheBust: v.optional(v.any()),
+  },
+  handler: async (ctx) => {
+    return (await ctx.db.query('messages').collect()).length
+  },
 })
 
-export const listUsers = query(async (ctx, { cacheBust }) => {
-  const _unused = cacheBust
-  return await ctx.db.query('users').collect()
+export const listUsers = query({
+  args: {},
+  handler: async (ctx) => {
+    return await ctx.db.query('users').collect()
+  },
 })
 
-export const countUsers = query(async (ctx, { cacheBust }) => {
-  const _unused = cacheBust
-  return (await ctx.db.query('users').collect()).length
+export const countUsers = query({
+  args: {
+    cacheBust: v.optional(v.any()),
+  },
+  handler: async (ctx) => {
+    return (await ctx.db.query('users').collect()).length
+  },
 })
 
-function choose(choices: string[]): string {
+function choose(choices: Array<string>): string {
   return choices[Math.floor(Math.random() * choices.length)]
 }
 
-function madlib(strings: TemplateStringsArray, ...choices: any[]): string {
+function madlib(strings: TemplateStringsArray, ...choices: Array<any>): string {
   return strings.reduce((result, str, i) => {
     return result + str + (choices[i] ? choose(choices[i]) : '')
   }, '')
@@ -44,12 +55,15 @@ const text = [
   "Could you let the customer know we've fixed their issue?",
 ]
 
-export const sendGeneratedMessage = mutation(async (ctx) => {
-  const body = madlib`${greetings} ${names}${punc} ${text}`
-  const user = await ctx.db.insert('users', {
-    name: 'user' + Math.floor(Math.random() * 1000),
-  })
-  await ctx.db.insert('messages', { body, user: user })
+export const sendGeneratedMessage = mutation({
+  args: {},
+  handler: async (ctx) => {
+    const body = madlib`${greetings} ${names}${punc} ${text}`
+    const user = await ctx.db.insert('users', {
+      name: 'user' + Math.floor(Math.random() * 1000),
+    })
+    await ctx.db.insert('messages', { body, user: user })
+  },
 })
 
 // TODO concurrency here
@@ -63,16 +77,19 @@ export const sendGeneratedMessages = action({
   },
 })
 
-export const clear = mutation(async (ctx) => {
-  await Promise.all([
-    ...(await ctx.db.query('messages').collect()).map((message) => {
-      ctx.db.delete(message._id)
-    }),
-    ...(await ctx.db.query('users').collect()).map((user) => {
-      ctx.db.delete(user._id)
-    }),
-  ])
-  for (const user of await ctx.db.query('users').collect()) {
-    await ctx.db.delete(user._id)
-  }
+export const clear = mutation({
+  args: {},
+  handler: async (ctx) => {
+    await Promise.all([
+      ...(await ctx.db.query('messages').collect()).map((message) => {
+        ctx.db.delete(message._id)
+      }),
+      ...(await ctx.db.query('users').collect()).map((user) => {
+        ctx.db.delete(user._id)
+      }),
+    ])
+    for (const user of await ctx.db.query('users').collect()) {
+      await ctx.db.delete(user._id)
+    }
+  },
 })

npm-packages/private-demos/tanstack-start/.prettierignore

@@ -0,0 +1,9 @@
+import { defineConfig, globalIgnores } from 'eslint/config'
+import { tanstackConfig } from '@tanstack/eslint-config'
+import convexPlugin from '@convex-dev/eslint-plugin'
+
+export default defineConfig([
+  ...tanstackConfig,
+  ...convexPlugin.configs.recommended,
+  globalIgnores(['convex/_generated', 'dist']),
+])

npm-packages/private-demos/tanstack-start/convex/README.md

@@ -10,7 +10,7 @@
     "dev:convex": "npx convex dev",
     "build": "vite build && tsc --noEmit",
     "start": "node .output/server/index.mjs",
-    "lint": "prettier --check '**/*' --ignore-unknown && eslint --ext .ts,.tsx ./app",
+    "lint": "prettier --check '**/*' --ignore-unknown && eslint .",
     "format": "prettier --write '**/*' --ignore-unknown"
   },
   "keywords": [],
@@ -27,13 +27,14 @@
     "react-dom": "^18.3.1"
   },
   "devDependencies": {
+    "@convex-dev/eslint-plugin": "workspace:*",
+    "@tanstack/eslint-config": "^0.3.0",
     "@types/react": "^18.2.65",
     "@types/react-dom": "^18.2.21",
     "@typescript-eslint/parser": "^6.7.4",
     "@vitejs/plugin-react": "^4.2.1",
     "concurrently": "~8.2.2",
-    "eslint": "^8.29.0",
-    "eslint-config-react-app": "~7.0.1",
+    "eslint": "^9.37.0",
     "prettier": "3.6.2",
     "typescript": "^5.9.2",
     "vite-tsconfig-paths": "^5.1.3",

npm-packages/private-demos/tanstack-start/convex/messages.ts

@@ -1,9 +1,9 @@
 import { createRouter } from '@tanstack/react-router'
-import { routeTree } from './routeTree.gen'
 import { ConvexQueryClient } from '@convex-dev/react-query'
 import { QueryClient } from '@tanstack/react-query'
 import { routerWithQueryClient } from '@tanstack/react-router-with-query'
 import { ConvexProvider, ConvexReactClient } from 'convex/react'
+import { routeTree } from './routeTree.gen'
 import { DefaultCatchBoundary } from './components/DefaultCatchBoundary'
 import { NotFound } from './components/NotFound'
 

npm-packages/private-demos/tanstack-start/eslint.config.mjs

@@ -1,11 +1,11 @@
-import { QueryClient } from '@tanstack/react-query'
 import {
-  createRootRouteWithContext,
   HeadContent,
-  Scripts,
   Outlet,
+  Scripts,
+  createRootRouteWithContext,
 } from '@tanstack/react-router'
 import * as React from 'react'
+import type { QueryClient } from '@tanstack/react-query'
 
 export const Route = createRootRouteWithContext<{ queryClient: QueryClient }>()(
   {

npm-packages/private-demos/tanstack-start/package.json

@@ -1,7 +1,7 @@
 import { createFileRoute } from '@tanstack/react-router'
 import { useMutation, useSuspenseQuery } from '@tanstack/react-query'
-import { api } from '../../convex/_generated/api'
 import { convexQuery, useConvexAction } from '@convex-dev/react-query'
+import { api } from '../../convex/_generated/api'
 
 export const Route = createFileRoute('/simple-sibling-queries')({
   component: SimpleSiblingQueries,