stop using _modules.by_deleted (#25075)

the `deleted` field is always false. but we can't delete it yet because we're still accessing the table with the `by_deleted` index. remove all usages of `by_deleted` index.

GitOrigin-RevId: 76c9957c94886a61aa7f83974524142e5a12d105

Author: ldanilek

crates/model/src/modules/mod.rs

@@ -13,7 +13,6 @@ use common::{
         BinaryKey,
         Interval,
     },
-    maybe_val,
     query::{
         IndexRange,
         IndexRangeExpression,
@@ -166,15 +165,7 @@ impl<'a, RT: Runtime> ModuleModel<'a, RT> {
     pub async fn get_all_metadata(
         &mut self,
     ) -> anyhow::Result<Vec<ParsedDocument<ModuleMetadata>>> {
-        let index_range = IndexRange {
-            index_name: MODULE_INDEX_BY_DELETED.clone(),
-            range: vec![IndexRangeExpression::Eq(
-                DELETED_FIELD.clone(),
-                maybe_val!(false),
-            )],
-            order: Order::Asc,
-        };
-        let index_query = Query::index_range(index_range);
+        let index_query = Query::full_table_scan(MODULES_TABLE.clone(), Order::Asc);
         let mut query_stream = ResolvedQuery::new(self.tx, index_query)?;
 
         let mut modules = Vec::new();

npm-packages/system-udfs/convex/_system/frontend/modules.ts

@@ -13,7 +13,7 @@ export const getSourceCode = queryPrivateSystem({
   handler: async ({ db }, { path }): Promise<string | null> => {
     const module = await db
       .query("_modules")
-      .withIndex("by_deleted", (q) => q.eq("deleted", false).eq("path", path))
+      .withIndex("by_path", (q) => q.eq("path", path))
       .unique();
     if (!module) {
       return null;
@@ -53,9 +53,7 @@ export const list = queryPrivateSystem({
   args: {},
   handler: async ({ db }): Promise<[string, Module][]> => {
     const result: [string, Module][] = [];
-    for await (const module of db
-      .query("_modules")
-      .withIndex("by_deleted", (q) => q.eq("deleted", false))) {
+    for await (const module of db.query("_modules")) {
       if (module.path.startsWith("_")) {
         continue;
       }

npm-packages/system-udfs/convex/schema.ts

@@ -275,9 +275,7 @@ export default defineSchema({
     path: v.string(),
     latestVersion: v.int64(),
     deleted: v.boolean(),
-  })
-    .index("by_path", ["path"])
-    .index("by_deleted", ["deleted", "path"]),
+  }).index("by_path", ["path"]),
   _module_versions: defineTable({
     module_id: v.id("_modules"),
     source: v.string(),