Skip to content

Commit cd40166

Browse files
sjuddConvex, Inc.
authored andcommitted
Make FragmentedTextSegment's primitives optional (#26443)
GitOrigin-RevId: 3b4edfd63af4faee99d69fdb001eb46138dafa87
1 parent d715cfa commit cd40166

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

crates/common/src/bootstrap_model/index/text_index/index_snapshot.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,10 @@ impl From<FragmentedTextSegment> for pb::searchlight::FragmentedTextSegment {
5353
id_tracker: storage_key_from_object_key(value.id_tracker_key),
5454
deleted_terms_table: storage_key_from_object_key(value.deleted_terms_table_key),
5555
alive_bitset: storage_key_from_object_key(value.alive_bitset_key),
56-
num_indexed_documents: value.num_indexed_documents,
57-
num_deleted_documents: value.num_deleted_documents,
58-
size_bytes_total: value.size_bytes_total,
59-
id: value.id,
56+
num_indexed_documents: Some(value.num_indexed_documents),
57+
num_deleted_documents: Some(value.num_deleted_documents),
58+
size_bytes_total: Some(value.size_bytes_total),
59+
id: Some(value.id),
6060
}
6161
}
6262
}
@@ -86,10 +86,10 @@ impl TryFrom<pb::searchlight::FragmentedTextSegment> for FragmentedTextSegment {
8686
.context("Missing alive bitset")?
8787
.storage_key
8888
.try_into()?,
89-
num_indexed_documents: value.num_indexed_documents,
90-
num_deleted_documents: value.num_deleted_documents,
91-
size_bytes_total: value.size_bytes_total,
92-
id: value.id,
89+
num_indexed_documents: value.num_indexed_documents.context("Missing num indexed")?,
90+
num_deleted_documents: value.num_deleted_documents.context("Missing num deleted")?,
91+
size_bytes_total: value.size_bytes_total.context("Missing size bytes total")?,
92+
id: value.id.context("Missing id")?,
9393
})
9494
}
9595
}

crates/pb/protos/searchlight.proto

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -127,14 +127,14 @@ message TextCompactionRequest {
127127
}
128128

129129
message FragmentedTextSegment {
130-
StorageKey segment = 1;
131-
StorageKey id_tracker = 2;
132-
StorageKey deleted_terms_table = 3;
133-
StorageKey alive_bitset = 4;
134-
uint64 num_indexed_documents = 5;
135-
uint64 num_deleted_documents = 6;
136-
uint64 size_bytes_total = 7;
137-
string id = 8;
130+
optional StorageKey segment = 1;
131+
optional StorageKey id_tracker = 2;
132+
optional StorageKey deleted_terms_table = 3;
133+
optional StorageKey alive_bitset = 4;
134+
optional uint64 num_indexed_documents = 5;
135+
optional uint64 num_deleted_documents = 6;
136+
optional uint64 size_bytes_total = 7;
137+
optional string id = 8;
138138
}
139139

140140
message TextCompactionResponse {

0 commit comments

Comments
 (0)