Skip to content

Commit 9250b9f

Browse files
Merge branch 'master' into copy-qr
2 parents 2335131 + b611684 commit 9250b9f

File tree

8 files changed

+872
-417
lines changed

8 files changed

+872
-417
lines changed

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ We welcome and appreciate new contributions! 🎉 To get started, [Refer to SETU
7676

7777
#### 🎨 Designer
7878

79-
- Have a look at our [Open source Design guide](https://github.com/getAlby/lightning-browser-extension/wiki/Open-source-Design)
8079
- Check out the issues that have specifically been [marked with "design"](https://github.com/getAlby/lightning-browser-extension/issues?q=is%3Aopen+is%3Aissue+label%3A%22design%22)
8180
- You can find and copy the current version of the extension in this Figma file: [Alby Extension Master Design](https://www.figma.com/file/O49NS4o3IjWwmHvFLncTy6/Alby-Extension-Master-Design?node-id=0%3A1&t=rd4dQkDtwZ4Nuuqo-1)
8281

@@ -113,7 +112,7 @@ WebLN is a library and set of specifications for lightning apps and client provi
113112

114113
#### Is there a bounty program and can I contribute?
115114

116-
Yes. Thanks to generous donors, Alby is able to offer several bounties. You can find them on our [Wiki page](https://github.com/getAlby/lightning-browser-extension/wiki/Bounties). If you want to support Alby's bounty program, please donate [here](https://getalby.com/bounties). We greatly appreciate your contribution! 🙏
115+
Yes. Thanks to generous donors, Alby is able to offer several bounties. You can find them on our [Alby Guides](https://guides.getalby.com/developer-guide/developer-guide/bounties/). If you want to support Alby's bounty program, please donate [here](https://getalby.com/p/bounties). We greatly appreciate your contribution! 🙏
117116

118117
## ⚡️ Donations
119118

doc/SETUP.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,6 @@ This guide helps you run the extension in desktop browsers.
5959
- Load the extension via `opera:extensions`
6060
- Check the `Developer Mode` and load as unpacked from extension’s extracted directory.
6161

62-
To connect to a remote development LND node you can use a [test account](https://github.com/bumi/lightning-browser-extension/wiki/Test-setup)
63-
6462
## 📱 Firefox Android Setup
6563

6664
Alby extension is actively maintained for Firefox on Android. Follow the [SETUP_ANDROID.md](./SETUP_ANDROID.md) guide to install and debug it.
@@ -98,7 +96,7 @@ Some ways you can work around this are:
9896

9997
### How to Test Different Connectors Supported by the Extension?
10098

101-
By default, Alby and NWC (Nostr Wallet Connect) connectors are sufficient for testing UI changes and core functionality. However, if you need to test specific connectors like LND, CLN, or LNbits, you can [Start the lightning network test environment locally and link to the Alby Browser Extension](https://github.com/getAlby/lightning-browser-extension/wiki/Start-the-lightning-network-test-environment-locally-and-link-to-the-Alby)
99+
By default, Alby and NWC (Nostr Wallet Connect) connectors are sufficient for testing UI changes and core functionality. However, if you need to test specific connectors like LND, CLN, or LNbits, you can run your own local lightning network and you can use [Lightning Polar](https://lightningpolar.com/) which helps you to spin up local instances.
102100

103101
## 📂 Project Structure
104102

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "lightning-browser-extension",
3-
"version": "3.14.0",
3+
"version": "3.14.1",
44
"description": "Lightning browser extension",
55
"private": true,
66
"repository": "https://github.com/bumi/lightning-browser-extension.git",

src/extension/background-script/actions/setup/setIcon.ts

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ import browser, { Runtime } from "webextension-polyfill";
22
import { isManifestV3 } from "~/common/utils/mv3";
33
import { MessageSetIcon } from "~/types";
44

5-
import state from "../../state";
6-
75
// Store all tabs with their respective icon
86
const tabIcons = new Map<number, string>();
97

@@ -46,7 +44,27 @@ const setIcon = async (icon: string, tabId: number): Promise<void> => {
4644

4745
tabIcons.set(tabId, icon);
4846

49-
const theme = state.getState().settings.theme == "dark" ? "_dark" : "";
47+
// For Chrome (Manifest V3): Use browser theme (prefers-color-scheme)
48+
// For Firefox (Manifest V2): theme_icons in manifest.json handles OS-based icons automatically
49+
let theme = "";
50+
if (isManifestV3) {
51+
try {
52+
const results = await browser.scripting.executeScript({
53+
target: { tabId },
54+
func: () => {
55+
return window.matchMedia &&
56+
window.matchMedia("(prefers-color-scheme: dark)").matches
57+
? "dark"
58+
: "light";
59+
},
60+
});
61+
theme = results[0]?.result === "dark" ? "_dark" : "";
62+
} catch (error) {
63+
console.warn("Failed to detect browser theme, using default:", error);
64+
theme = "";
65+
}
66+
}
67+
5068
const iconsParams = {
5169
path: {
5270
// it's looking relative from the "js" folder
@@ -63,4 +81,4 @@ const setIcon = async (icon: string, tabId: number): Promise<void> => {
6381
: browser.browserAction.setIcon(iconsParams);
6482
};
6583

66-
export { setIcon, setIconMessageHandler, ExtensionIcon };
84+
export { ExtensionIcon, setIcon, setIconMessageHandler };

src/i18n/locales/de/translation.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,18 @@
33
"welcome": {
44
"set_password": {
55
"choose_password": {
6-
"label": "Wähle einen Passcode zum Entsperren:"
6+
"label": "Wählen Sie einen Entsperrcode:"
77
},
88
"errors": {
99
"mismatched_password": "Die Passcodes stimmen nicht überein.",
10-
"enter_password": "Bitte gebe einen Passcode ein.",
10+
"enter_password": "Bitte geben Sie einen Passcode ein.",
1111
"confirm_password": "Bitte bestätige deinen Passcode."
1212
},
1313
"confirm_password": {
14-
"label": "Vergewisser dich, dass du es richtig eingegeben hast:"
14+
"label": "Vergewissere dich, dass du es richtig eingegeben hast:"
1515
},
16-
"description1": "Lege ein Passcode fest, um die Alby-Erweiterung in diesem Browser zu entsperren",
17-
"description2": "Das Password zum Entsperren kann nicht wiederhergestellt, aber geändert werden ",
16+
"description1": "Lege einen Passcode fest, um die Alby-Erweiterung in diesem Browser zu entsperren.",
17+
"description2": "Der Passcode zum Entsperren kann nicht wiederhergestellt, aber geändert werden.",
1818
"title": "Passcode zum Entsperren der Erweiterung festlegen"
1919
},
2020
"test_connection": {
@@ -379,7 +379,7 @@
379379
},
380380
"show_fiat": {
381381
"title": "Sats in Fiat",
382-
"subtitle": "Beträge in die ausgewählte Währung umrechnen (z.B.: EUR)"
382+
"subtitle": "Immer in die ausgewählte Währung zum ausgewählten Wechselkurs umrechnen"
383383
},
384384
"personal_data": {
385385
"title": "Persönliche Daten",
@@ -655,7 +655,7 @@
655655
},
656656
"send": {
657657
"input": {
658-
"label": "Rechnung, Lightning-Adresse oder LNURL",
658+
"label": "Empfänger",
659659
"hint": "Rechnung, Lightning-Adresse, LNURL",
660660
"hint_with_bitcoin_address": "Rechnung, Lightning-Adresse, LNURL oder Bitcoin-Adresse"
661661
},

0 commit comments

Comments
 (0)