fix: Prevent crash when test fails on a different thread

When a test fails due to an exception thrown on a different thread, the test class itself may not appear in the exception's stack trace. The agent was previously unable to handle this scenario, crashing with a `java.lang.InternalError` because it could not find a stack frame matching the test class.

This commit introduces a more robust heuristic to find the most likely source of the failure. If an exact match for the test class is not found, the agent now falls back to the last seen stack frame that does not belong to a known testing or Java framework. This prevents the crash and correctly identifies the failure location.

A regression test has been added to simulate this cross-thread exception scenario and verify the fix.

Author: dividedmind

agent/src/main/java/com/appland/appmap/process/hooks/test/TestSupport.java

@@ -63,19 +63,54 @@ private static void startRecording(TestDetails details, Recorder.Metadata metada
     RecordingSupport.startRecording(details, metadata);
   }
 
+  private static boolean isFrameworkClass(String className) {
+    return className.startsWith("org.junit") ||
+            className.startsWith("org.testng") ||
+            className.startsWith("com.intellij") ||
+            className.startsWith("java.") ||
+            className.startsWith("jdk");
+  }
+
+  /**
+   * Finds the most relevant stack frame for a test failure.
+   * <p>
+   * The primary goal is to find the stack frame that corresponds to the test
+   * class itself. However, in some scenarios (e.g., when an assertion fails on
+   * a different thread), the test class may not be in the stack trace at all.
+   * <p>
+   * To handle this, we use a fallback heuristic: we find the last stack frame
+   * that is not a known framework class. This is usually the entry point into
+   * the user's code and the most likely source of the failure.
+   *
+   * @param self      The test class instance
+   * @param exception The exception that caused the failure
+   * @return The most relevant stack frame
+   * @throws InternalError if no suitable stack frame can be found
+   */
   static StackTraceElement findErrorFrame(Object self, Throwable exception) throws InternalError {
     String selfClass = self.getClass().getName();
-    StackTraceElement errorFrame = null;
+    StackTraceElement fallbackFrame = null;
+
     for (StackTraceElement frame : exception.getStackTrace()) {
       if (frame.getClassName().equals(selfClass)) {
-        errorFrame = frame;
-        break;
+        // This is the ideal case: we found the test class in the stack trace.
+        return frame;
+      }
+      if (!isFrameworkClass(frame.getClassName())) {
+        // This is a potential candidate for the fallback frame. We'll keep
+        // track of the last one we see, as it's the most likely to be the
+        // entry point into the user's code.
+        fallbackFrame = frame;
       }
     }
-    if (errorFrame == null) {
-      throw new InternalError("no stack frame matched test class");
+
+    if (fallbackFrame != null) {
+      // We didn't find the test class, but we have a good fallback.
+      return fallbackFrame;
     }
-    return errorFrame;
+
+    // We couldn't find any suitable frame.
+    throw new InternalError("no stack frame matched test class");
   }
 
   private static boolean hasTestAnnotation(ClassLoader cl, Method stackMethod) {

agent/test/test-frameworks/frameworks.bats

@@ -52,7 +52,7 @@ run_framework_test() {
 
   assert_json_eq '.metadata.test_status' "failed"
   assert_json_contains '.metadata.test_failure.message' 'false is not true'
-  assert_json_eq '.metadata.test_failure.location' "src/test/java/org/springframework/samples/petclinic/JunitTests.java:20"
+  assert_json_eq '.metadata.test_failure.location' "src/test/java/org/springframework/samples/petclinic/JunitTests.java:21"
 }
 
 @test "test status set for failed test in testng" {
@@ -104,4 +104,12 @@ run_framework_test() {
 
   output="$(< tmp/appmap/testng/org_springframework_samples_petclinic_TestngTests_testItThrows.appmap.json)"
   assert_json_eq '.metadata.test_status' "succeeded"
+}
+
+@test "No InternalError on different thread exception" {
+  run_framework_test "junit" "JunitTests.offThreadExceptionTest"
+  assert_failure
+  # The test should fail with a RuntimeException, but not an InternalError
+  assert_output --partial "java.lang.RuntimeException"
+  refute_output --partial "java.lang.InternalError"
 }

agent/test/test-frameworks/src/test/java/org/springframework/samples/petclinic/JunitTests.java

@@ -1,5 +1,6 @@
 package org.springframework.samples.petclinic;
 
+import static java.util.concurrent.Executors.newSingleThreadExecutor;
 import static org.junit.Assert.assertTrue;
 
 import com.appland.appmap.annotation.NoAppMap;
@@ -38,4 +39,28 @@ public void testAnnotatedClassNotRecorded() {
     }
   }
 
+  private class ExecutorRunner {
+    public Throwable run() {
+      var executor = newSingleThreadExecutor();
+      var future = executor.submit(() -> {
+        throw new RuntimeException("Off-thread exception for testing");
+      });
+      try {
+        future.get();
+      } catch (java.util.concurrent.ExecutionException e) {
+        return e.getCause();
+      } catch (InterruptedException e) {
+        Thread.currentThread().interrupt();
+      } finally {
+        executor.shutdown();
+      }
+      return null;
+    }
+  }
+
+  @Test
+  public void offThreadExceptionTest() throws Throwable {
+    var throwable = new ExecutorRunner().run();
+    throw throwable;
+  }
 }