Duplicate page created after editing when using 3-digits (< 100) prefix

[pmetras]

Context

I'm migrating a site with hundreds of pages from Pico CMS. I've written a script to move files from Pico's structure to Grav's one, using 3-digits folder prefix. When editing some pages, a duplicate page is created in a 2 digits-prefix folder with the same name.

How to reproduce the problem

Here is the minimal setup to reproduce the case:

1. Download Grav+Admin: wget https://getgrav.org/download/core/grav-admin/1.7.49.5 and install it. I can't use the latest version https://getgrav.org/download/core/grav-admin/latest as it requires PHP version > 8.3 and my server uses PHP 8.2.29. Update the plugins to the latest versions ().
2. From the command line, create a page with a 3-digits prefix:

$ pwd
/var/www/grav/user/pages
$ mkdir 005.test
$ cp 01.home/default.md 005.test/

3. Go to edit the test pages. Before:

4. In the editor, the page directory is correct:

5. Save the page:

After the save, you can see that the directory of the page has changed, from 005.test to 05.test.

How to fix it

The bug occurs only for pages with prefixes in the range 000 to 099, or 0 to 9.

One could say that this is desired and that the user must always use fixed-length 2-digits prefix. This rule is probably too strict as I have hundreds of pages.

The best way would probably be to have a prefix_pattern in the site.yaml config file where one can define what the ordering pattern is: prefix_pattern: DDD.

Mentions

Already mentioned in

• Duplicate page file created when using 3-digit ordering prefixes #2257
• https://discourse.getgrav.org/t/page-edit-problems/27886

[Xoriander]

If I see it correctly, there are at least 7 files that have to be adapted for this:

grep -irn --include=\*.php "sprintf('%02d" user/plugins/admin/ user/plugins/flex-objects/ system/src/Grav:

File	Line	Expression
user/plugins/admin/classes/plugin/AdminController.php	3092	$ordering = $order ? sprintf('%02d.', $order) : '';
user/plugins/flex-objects/classes/Admin/AdminController.php	435	$orderOfNewFolder = $maxOrder ? sprintf('%02d.', $maxOrder+1) : '';
system/src/grav/Common/Flex/Types/Pages/Storage/PageStorage.php	156	$key .= is_numeric($order) ? sprintf('%02d.%s', $order, $folder) : $folder;
system/src/grav/Common/Page/Page.php	1846	$order = $var ? sprintf('%02d.', (int)$var) : '';
system/src/grav/Framework/Flex/Pages/FlexPageObject.php	445	$elements['storage_key'] = $order ? sprintf('%02d.%s', $order, $folder) : $folder;
system/src/grav/Framework/Flex/Pages/Traits/PageContentTrait.php	347	return $property !== false ? sprintf('%02d.', $property) : false;
system/src/grav/Framework/Flex/Pages/Traits/PageLegacyTrait.php	354	$parts[] = $order ? sprintf('%02d.%s', $order, $folder) : $folder;

In Grav 1.8.0-beta.28