Safe Upgrade dialog is running forever

[Xoriander]

Grav Version: 1.8.0-beta.28
PHP Version: 8.4.12
Grav System Config changes: None

Steps to reproduce:

1. Log in to Admin interface when upgrade is available.
2. Click Update Grav Now
3. Click Start Safe Upgrade

Expected:

Grav should be updated to the version mentioned in the notification saying that an upgrade is available.

Actual:

Safe Upgrade dialog is running forever showing this window:

Output of the worker log:

(user/data/upgrades/jobs/job-2026xyz/worker.log)

Job job-2026xyz queued
Command: nohup '/usr/bin/php' '/grav/bin/grav' safe-upgrade:run --job='job-2026xyz' >> '/grav/user/data/upgrades/jobs/job-2026xyz/worker.log' 2>&1 &
PHP Fatal error:  Uncaught RuntimeException: Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 8.3.0". You are running 7.4.33-nmm7. in /grav/vendor/composer/platform_check.php:22
Stack trace:
#0 /grav/vendor/composer/autoload_real.php(25): require()
#1 /grav/vendor/autoload.php(22): ComposerAutoloaderInitb39160710f90a14d6be86b6c7237404a::getLoader()
#2 /grav/bin/grav(26): require('/www/...')
#3 {main}
  thrown in /grav/vendor/composer/platform_check.php on line 22

Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 8.3.0". You are running 7.4.33

Additional details:

Running the Safe Upgrade from cli with the versioned php executable works as expexted:
php84 bin/gpm selfupgrade --force --safe

Reason:

This is a special issue caused by the webserver configuration because the php version for the cli differs from the php version used by apache server. The Problem is that the hoster only allows to set the default version for the frontend.

The php executable with the incompatible version was set at this point:

grav-plugin-admin/classes/plugin/SafeUpgradeManager.php

Lines 590 to 592 in c6c895d

	try {
	$finder = new PhpExecutableFinder();
	$phpPath = $finder->find(false) ?: PHP_BINARY;

Possible Solution:

A solution could be to set the php path to the versioned executable:

$phpExeName = 'php' . PHP_MAJOR_VERSION . PHP_MINOR_VERSION;
$finder = new ExecutableFinder();
$phpPath = $finder->find($phpExeName);

if (!$phpPath) {
    $finder = new PhpExecutableFinder();
    $phpPath = $finder->find(false) ?: PHP_BINARY;
}

But the versioned name can differ, I also see 'php' . PHP_MAJOR_VERSION . '.' . PHP_MINOR_VERSION under debian.
A new system setting option for the name or the path of the versioned php executable for cli commands could help.

[Xoriander]

Another possible solution could be to trigger the fallback in AdminController.php:

grav-plugin-admin/classes/plugin/AdminController.php

Lines 875 to 882 in c6c895d

	$status = $result['status'] ?? 'error';
	if ($status === 'error') {
	$manager->clearJobContext();
	$result = $manager->run($options);
	$status = $result['status'] ?? 'error';
	$result['fallback'] = true;
	}

Before running the background jobs (SafeUpgradeManager.php L605-L633) it could be done with:

// Check PHP binary is running in CLI without problems
$commandLine = sprintf(
    '%s %s grav --version >> %s 2>&1',
    escapeshellarg($phpPath),
    escapeshellarg($gravPath),
    escapeshellarg($logPath)
);

try {
    file_put_contents($logPath, '[' . gmdate('c') . "] Command: {$commandLine}\n", FILE_APPEND);
} catch (Throwable $e) {
    // ignore log write failures
}

$process = Process::fromShellCommandline($commandLine, GRAV_ROOT, null, null, 3);
$process->disableOutput();
$process->mustRun();

$process->mustRun() throws a ProcessFailedException if it fails.

After this the update will be executed successfully through the fallback.

[rhukster]

The fundamental problem is you are on PHP 7.4, you need at least PHP 8.3. I'm wondering if you are not even getting to the 'check' of PHP because it's failing before you even get there. I'm actually suprised you could get this far, even running on PHP 7.4 at all with Grav 1.8.. Have you changed your PHP version since installation?

[Xoriander]

Thanks for the reply! Its only the PHP version called by Process::fromShellCommandline which causes the problem because the webhoster only allows to set the PHP version for the frontend and this was /usr/sbin/php84-fpm. But in CLI I have to select a certain version e.g. php84 otherwise the standard was PHP 7.4.
I don't know at what interval the webhoster updates the standard for CLI...
To avoid this problem I can go without the update over the admin plugin. For now I close this Issue.