feat: show stack in frontend error messages

Author: paulrobertlloyd

packages/endpoint-auth/lib/controllers/documentation.js

@@ -7,6 +7,7 @@ export const documentationController = (error, request, response, next) => {
     response.render("auth", {
       title: response.locals.__("auth.guidance.title"),
       error: error.message,
+      error_details: error.stack,
     });
   } else if (request.accepts("json")) {
     return next(error);

packages/endpoint-files/lib/controllers/delete.js

@@ -42,6 +42,7 @@ export const deleteController = {
         title: response.locals.__("files.delete.title"),
         parent: { text: fileName },
         error: error.message,
+        error_details: error.stack,
       });
     }
   },

packages/endpoint-files/lib/controllers/form.js

@@ -54,6 +54,7 @@ export const formController = {
       response.render("file-form", {
         title: response.locals.__("files.upload.title"),
         error: error.message,
+        error_details: error.stack,
       });
     }
   },

packages/endpoint-posts/lib/controllers/delete.js

@@ -45,6 +45,7 @@ export const deleteController = {
         title: response.locals.__(`posts.${action}.title`),
         parent: { text: postName },
         error: error.message,
+        error_details: error.stack,
       });
     }
   },

packages/endpoint-posts/lib/controllers/form.js

@@ -92,6 +92,7 @@ export const formController = {
           postTypeName.toLowerCase()
         ),
         error: error.message,
+        error_details: error.stack,
       });
     }
   },

packages/endpoint-posts/tests/integration/500-post-create.js

@@ -23,7 +23,7 @@ test("Returns 500 error creating post", async (t) => {
   ).textContent;
 
   t.is(response.status, 500);
-  t.is(result, "Test store: Unauthorized");
+  t.regex(result, /\bTest store: Unauthorized\b/g);
 
   server.close(t);
 });

packages/endpoint-share/lib/controllers/share.js

@@ -69,6 +69,7 @@ export const shareController = {
         name,
         bookmarkOf,
         error: error.message,
+        error_details: error.stack,
         minimalui: request.params.path === "bookmarklet",
       });
     }

packages/endpoint-share/tests/integration/400-post-share.js

@@ -17,9 +17,9 @@ test("Returns 400 error publishing post", async (t) => {
   const result = dom.window.document;
 
   t.is(response.status, 400);
-  t.is(
+  t.regex(
     result.querySelector(".notification--error p").textContent,
-    "No bearer token provided by request"
+    /\bNo bearer token provided by request\b/g
   );
 
   server.close(t);

packages/indiekit/lib/indieauth.js

@@ -100,6 +100,7 @@ export const IndieAuth = class {
         return response.status(401).render("session/login", {
           title: response.locals.__("session.login.title"),
           error: error.message,
+          error_details: error.stack,
         });
       }
     };
@@ -172,6 +173,7 @@ export const IndieAuth = class {
         return response.render("session/login", {
           title: response.locals.__("session.login.title"),
           error: error.message,
+          error_details: error.stack,
         });
       }
     };