Invert boolean options for simplicity

Author: myleshorton

README.md

@@ -44,10 +44,10 @@ Samizdat is implemented as a standalone library ([`samizdat`](https://github.com
       "short_id": "0123456789abcdef",
       "server_name": "ok.ru",
       "fingerprint": "chrome",
-      "padding": true,
-      "jitter": true,
-      "tcp_fragmentation": true,
-      "record_fragmentation": true
+      "disable_padding": false,
+      "disable_jitter": false,
+      "disable_tcp_fragmentation": false,
+      "disable_record_fragmentation": false
     }
   ]
 }

option/samizdat.go

@@ -15,15 +15,15 @@ type SamizdatOutboundOptions struct {
 	ServerName  string `json:"server_name,omitempty"`  // cover site SNI (e.g. "ok.ru")
 	Fingerprint string `json:"fingerprint,omitempty"`  // "chrome" (default), "firefox", "safari"
 
-	// Traffic shaping (pointer types so unset is distinguishable from explicitly false)
-	Padding        *bool  `json:"padding,omitempty"`         // enable H2 DATA frame padding (default: true)
-	Jitter         *bool  `json:"jitter,omitempty"`          // enable timing jitter (default: true)
+	// Traffic shaping (enabled by default; set to true to disable)
+	DisablePadding bool   `json:"disable_padding,omitempty"` // disable H2 DATA frame padding
+	DisableJitter  bool   `json:"disable_jitter,omitempty"`  // disable timing jitter
 	MaxJitterMs    int    `json:"max_jitter_ms,omitempty"`   // max jitter in ms (default: 30)
 	PaddingProfile string `json:"padding_profile,omitempty"` // "chrome", "firefox" (default: "chrome")
 
-	// TCP fragmentation (Geneva-inspired)
-	TCPFragmentation    *bool `json:"tcp_fragmentation,omitempty"`    // fragment ClientHello (default: true)
-	RecordFragmentation *bool `json:"record_fragmentation,omitempty"` // fragment TLS records (default: true)
+	// TCP fragmentation (Geneva-inspired; enabled by default; set to true to disable)
+	DisableTCPFragmentation    bool `json:"disable_tcp_fragmentation,omitempty"`    // disable ClientHello fragmentation
+	DisableRecordFragmentation bool `json:"disable_record_fragmentation,omitempty"` // disable TLS record fragmentation
 
 	// Connection management
 	MaxStreamsPerConn int    `json:"max_streams_per_conn,omitempty"` // max H2 streams per TCP conn (default: 100)

protocol/samizdat/outbound.go

@@ -103,12 +103,12 @@ func NewOutbound(
 		PublicKey:           pubKey,
 		ShortID:             shortID,
 		Fingerprint:         options.Fingerprint,
-		Padding:             boolDefault(options.Padding, true),
-		Jitter:              boolDefault(options.Jitter, true),
+		Padding:             !options.DisablePadding,
+		Jitter:              !options.DisableJitter,
 		MaxJitterMs:         options.MaxJitterMs,
 		PaddingProfile:      options.PaddingProfile,
-		TCPFragmentation:    boolDefault(options.TCPFragmentation, true),
-		RecordFragmentation: boolDefault(options.RecordFragmentation, true),
+		TCPFragmentation:    !options.DisableTCPFragmentation,
+		RecordFragmentation: !options.DisableRecordFragmentation,
 		MaxStreamsPerConn:    options.MaxStreamsPerConn,
 		IdleTimeout:         idleTimeout,
 		ConnectTimeout:      connectTimeout,
@@ -181,10 +181,3 @@ func (o *Outbound) Close() error {
 	return nil
 }
 
-// boolDefault returns the value pointed to by p, or defaultVal if p is nil.
-func boolDefault(p *bool, defaultVal bool) bool {
-	if p != nil {
-		return *p
-	}
-	return defaultVal
-}

protocol/samizdat/samizdat_test.go

@@ -85,18 +85,6 @@ func validInboundOptions(t *testing.T) option.SamizdatInboundOptions {
 	}
 }
 
-// --- boolDefault tests ---
-
-func TestBoolDefault(t *testing.T) {
-	trueVal := true
-	falseVal := false
-
-	assert.True(t, boolDefault(&trueVal, false), "pointer to true should return true")
-	assert.False(t, boolDefault(&falseVal, true), "pointer to false should return false")
-	assert.True(t, boolDefault(nil, true), "nil should return default true")
-	assert.False(t, boolDefault(nil, false), "nil should return default false")
-}
-
 // --- NewInbound validation tests ---
 
 func TestNewInbound_InvalidPrivateKey(t *testing.T) {