refactor(tests): simplify issue repository usage in tests

Author: getmarkus

.trunk/trunk.yaml

@@ -23,13 +23,13 @@ lint:
     - [email protected]
     - [email protected]
     - [email protected]
-    - [email protected].369
+    - [email protected].372
     - [email protected]
     - [email protected]
-    - [email protected].0
-    - [email protected].5
+    - [email protected].1
+    - [email protected].7
     - [email protected]
-    - [email protected].5
+    - [email protected].12
 actions:
   enabled:
     - trunk-upgrade-available

app/tests/conftest.py

@@ -13,7 +13,7 @@
 from app.core.factory import create_app
 from app.resource_adapters.persistence.sqlmodel.database import get_engine
 from app.resource_adapters.persistence.sqlmodel.issues import Issue
-from config import Settings, get_settings
+from config import get_settings
 
 # Specify the custom .env file
 dotenv_path = Path(".env.testing")

app/tests/domain/test_issue.py

@@ -8,11 +8,13 @@ def test_initial_state():
     assert IssueState.OPEN.value == "OPEN"
     assert IssueState.CLOSED.value == "CLOSED"
 
+
 def test_is_open_property():
     """Test the is_open property returns correct values"""
     assert IssueState.OPEN.is_open is True
     assert IssueState.CLOSED.is_open is False
 
+
 def test_valid_transitions():
     """Test all valid state transitions"""
     # Test closing an open issue
@@ -29,6 +31,7 @@ def test_valid_transitions():
     new_state = state.transition(IssueTransitionType.REOPEN)
     assert new_state == IssueState.OPEN
 
+
 def test_invalid_transitions():
     """Test that invalid transitions raise appropriate errors"""
     # Test cannot close an already closed issue
@@ -43,6 +46,7 @@ def test_invalid_transitions():
         IssueState.OPEN.transition(IssueTransitionType.REOPEN)
     assert "Cannot perform REOPEN transition from state OPEN" in str(exc_info.value)
 
+
 def test_unknown_transition_type():
     """Test that using an undefined transition type raises an error"""
 
@@ -55,6 +59,7 @@ def __str__(self):
         IssueState.OPEN.transition(FakeTransitionType())
     assert "Unknown transition type: FAKE_TRANSITION" in str(exc_info.value)
 
+
 def test_transitions_immutability():
     """Test that the transitions dictionary cannot be modified at runtime"""
     transitions = IssueState.transitions()

app/tests/test_issues.py

@@ -1,6 +1,5 @@
 import pytest
 from fastapi.testclient import TestClient
-from loguru import logger
 from sqlmodel import Session
 
 from app.core.usecases.analyze_issue import AnalyzeIssue
@@ -14,14 +13,17 @@ def test_analyze_issue_command(client: TestClient, session: Session):
     issue_number = 1
     test_issue = Issue(issue_number=issue_number, issue_state=IssueState.OPEN)
 
-    repository = SQLModelIssueRepository(session)
+    uow = SQLModelIssueRepository(session)
 
-    repository.add(test_issue)
-    repository.commit()
-    retrieved_issue = repository.get_by_id(issue_number)
-    assert retrieved_issue.issue_number == issue_number
+    with uow:
+        uow.add(test_issue)
 
-    use_case = AnalyzeIssue(issue_number=issue_number, repo=repository)
+    with uow:
+        retrieved_issue = uow.get_by_id(issue_number)
+        assert retrieved_issue.issue_number == issue_number
+        assert retrieved_issue.issue_state == IssueState.OPEN
+
+    use_case = AnalyzeIssue(issue_number=issue_number, repo=uow)
     response = use_case.analyze()
     assert response.issue_number == issue_number
 
@@ -31,10 +33,10 @@ def test_analyze_issue_client(client: TestClient, session: Session):
     issue_number = 1
     test_issue = Issue(issue_number=issue_number, issue_state=IssueState.OPEN)
 
-    repository = SQLModelIssueRepository(session)
+    uow = SQLModelIssueRepository(session)
 
-    repository.add(test_issue)
-    repository.commit()
+    with uow:
+        uow.add(test_issue)
 
     response = client.post("/v1/issues/1/analyze")
     assert response.status_code == 200
@@ -45,11 +47,14 @@ def test_analyze_issue_not_found(client: TestClient, session: Session):
     # Test case 1: Successful analysis
     issue_number = 1
 
-    repository = SQLModelIssueRepository(session)
-    retrieved_issue = repository.get_by_id(issue_number)
-    assert retrieved_issue.issue_number == 0
+    uow = SQLModelIssueRepository(session)
+
+    with uow:
+        retrieved_issue = uow.get_by_id(issue_number)
+        assert retrieved_issue.issue_number == 0
+
+    use_case = AnalyzeIssue(issue_number=issue_number, repo=uow)
 
-    use_case = AnalyzeIssue(issue_number=issue_number, repo=repository)
     with pytest.raises(NotFoundException) as exc_info:
         use_case.analyze()
     assert exc_info.value.message == "Issue not found"
@@ -58,7 +63,7 @@ def test_analyze_issue_not_found(client: TestClient, session: Session):
     assert response.status_code == 404
 
 
-def test_analyze_issue_invalid_number(client: TestClient, session: Session):
+def test_analyze_issue_invalid_number(client: TestClient):
     """Test analyzing an issue with an invalid issue number."""
 
     response = client.post("/v1/issues/abc/analyze")
@@ -70,8 +75,17 @@ def test_analyze_issue_invalid_number(client: TestClient, session: Session):
     assert error_detail[0]["loc"] == ["path", "issue_number"]
 
 
-def test_analyze_issue_unauthorized(client: TestClient):
+def test_analyze_issue_unauthorized(client: TestClient, session: Session):
     # Test case 3: Unauthorized access
+
+    issue_number = 456
+    test_issue = Issue(issue_number=issue_number, issue_state=IssueState.OPEN)
+
+    uow = SQLModelIssueRepository(session)
+
+    with uow:
+        uow.add(test_issue)
+
     response = client.post("/v1/issues/456/analyze")
     assert response.status_code == 401
     assert response.json() == {"detail": "Unauthorized"}