Merge pull request #15 from getmarkus/cm-branch-13

feat(tests): add session and client fixtures for tests

Author: getmarkus

app/resource_adapters/persistence/sqlmodel/database.py

@@ -2,6 +2,7 @@
 
 from loguru import logger
 from sqlalchemy.engine import Engine
+from sqlalchemy.pool import StaticPool
 from sqlmodel import Session, SQLModel, create_engine
 
 from config import Settings
@@ -24,14 +25,14 @@ def get_engine(database_url: str | None = None) -> Engine:
     if database_url is None:
         database_url = Settings.get_settings().database_url
 
-    _engine = create_engine(
-        database_url, echo=True
-    )
+    _engine = create_engine(database_url, echo=True)
     # Initialize database if using SQLModel
-    if Settings.get_settings().execution_mode == "sqlmodel" and not Settings.get_settings().migrate_database:
+    if (
+        Settings.get_settings().execution_mode == "sqlmodel"
+        and not Settings.get_settings().migrate_database
+    ):
         logger.info("Creating database tables...")
         SQLModel.metadata.create_all(_engine)
         logger.info("Database tables created successfully")
-        
-    return _engine
 
+    return _engine

app/tests/conftest.py

@@ -0,0 +1,29 @@
+import pytest
+from fastapi.testclient import TestClient
+from sqlmodel import Session, delete
+
+from app.resource_adapters.persistence.sqlmodel.database import get_engine, get_db
+from app.resource_adapters.persistence.sqlmodel.issues import Issue
+from main import app
+
+
+@pytest.fixture(name="session", autouse=True)
+def session_fixture():
+
+    with Session(get_engine()) as session:
+        yield session
+        statement = delete(Issue)
+        session.exec(statement)
+        session.commit()
+
+
+@pytest.fixture(name="client")
+def client_fixture(session: Session):
+    def get_session_override():  
+        return session
+
+    app.dependency_overrides[get_db] = get_session_override
+
+    with TestClient(app) as client:
+        yield client
+        app.dependency_overrides.clear()

app/tests/test_issues.py

@@ -1,38 +1,13 @@
 import pytest
 from fastapi.testclient import TestClient
-from sqlmodel import Session, SQLModel, create_engine
-from sqlmodel.pool import StaticPool
+from sqlmodel import Session
 
-from main import app
 from app.core.usecases.analyze_issue import AnalyzeIssue
 from app.domain.issue import Issue, IssueState
 from app.interface_adapters.exceptions import NotFoundException
-from app.resource_adapters.persistence.sqlmodel.database import get_db
 from app.resource_adapters.persistence.sqlmodel.issues import SQLModelIssueRepository
 
 
-# https://sqlmodel.tiangolo.com/tutorial/fastapi/tests/
-@pytest.fixture(name="session")
-def session_fixture():
-    engine = create_engine(
-        "sqlite://", connect_args={"check_same_thread": False}, poolclass=StaticPool
-    )
-    SQLModel.metadata.create_all(engine)
-    with Session(engine) as session:
-        yield session
-
-
-@pytest.fixture(name="client")
-def client_fixture(session: Session):
-    def get_session_override():
-         return session
-
-    app.dependency_overrides[get_db] = get_session_override
-    with TestClient(app, raise_server_exceptions=False) as client:
-        yield client
-        app.dependency_overrides.clear()
-
-
 def test_analyze_issue_command(client: TestClient, session: Session):
     # Test case 1: Successful analysis
     issue_number = 1
@@ -80,6 +55,7 @@ def test_analyze_issue_not_found(client: TestClient, session: Session):
 
     response = client.post("/issues/1/analyze")
     assert response.status_code == 404
+    assert response.json() == {"version": 1, "issue_number": 1}
 
 
 def test_analyze_issue_invalid_number(client: TestClient, session: Session):

config.py

@@ -17,7 +17,6 @@ class Settings(BaseSettings):
     env_smoke_test: str = ""
     project_name: str = ""
     database_url: str = "sqlite:///./issues.db"
-    #database_url: str = "sqlite://"
     migrate_database: bool = False
     # BACKEND_CORS_ORIGINS is a JSON-formatted list of origins
     # e.g: '["http://localhost", "http://localhost:4200", "http://localhost:3000", \

pyproject.toml

@@ -23,11 +23,4 @@ requires = ["hatchling"]
 build-backend = "hatchling.build"
 
 [dependency-groups]
-dev = [
-    "pytest>=8.3.4",
-]
-
-[tool.pytest.ini_options]
-asyncio_mode = "auto"
-anyio_backend = "asyncio"
-asyncio_default_fixture_loop_scope = "function"
+dev = ["pytest>=8.3.4"]