Merge pull request #11 from getmarkus/cm-branch-10

updated test

Author: getmarkus

tests/test_issues.py

@@ -1,12 +1,14 @@
-import pytest
 from fastapi.testclient import TestClient
-from sqlmodel import Session, SQLModel, create_engine
+import pytest
+from sqlmodel import SQLModel, Session, create_engine
 from sqlmodel.pool import StaticPool
 
 from main import app
 from src.domain.issue import Issue, IssueState
 from src.resource_adapters.persistence.sqlmodel.database import get_db
 from src.resource_adapters.persistence.sqlmodel.issues import SQLModelIssueRepository
+from src.app.usecases.analyze_issue import AnalyzeIssue
+from src.interface_adapters.exceptions import NotFoundException
 
 
 # https://sqlmodel.tiangolo.com/tutorial/fastapi/tests/
@@ -34,31 +36,59 @@ def get_session_override():
 
 
 class TestAnalyzeIssue:
-    def test_analyze_issue(self, client: TestClient, session: Session):
+    def test_analyze_issue_command(self, client: TestClient, session: Session):
         # Test case 1: Successful analysis
         issue_number = 1
         test_issue = Issue(issue_number=issue_number, issue_state=IssueState.OPEN)
 
         repository = SQLModelIssueRepository(session)
 
         repository.add(test_issue)
+        repository.commit()
+        retrieved_issue = repository.get_by_id(issue_number)
+        assert retrieved_issue.issue_number == issue_number
+
+        use_case = AnalyzeIssue(issue_number=issue_number, repo=repository)
+        response = use_case.analyze()
+        assert response.issue_number == issue_number
 
+    def test_analyze_issue_client(self, client: TestClient, session: Session):
+        # Test case 1: Successful analysis
         response = client.post("/issues/1/analyze")
         #assert response.status_code == 200
         assert response.json() == {"version": 1, "issue_number": 1}
+    
+    def test_analyze_issue_not_found(self, client: TestClient, session: Session):
+        # Test case 1: Successful analysis
+        issue_number = 1
+
+        repository = SQLModelIssueRepository(session)
+        retrieved_issue = repository.get_by_id(issue_number)
+        assert retrieved_issue.issue_number == 0
+
+        use_case = AnalyzeIssue(issue_number=issue_number, repo=repository)
+        with pytest.raises(NotFoundException) as exc_info:
+            use_case.analyze()
+        assert exc_info.value.message == "Issue not found"
+
+        response = client.post("/issues/1/analyze")
+        assert response.status_code == 404
+
+    def test_analyze_issue_invalid_number(self, client: TestClient, session: Session):
+        """Test analyzing an issue with an invalid issue number."""
 
-        # Test case 2: Invalid issue number
-        try:
-            response = client.post("/issues/abc/analyze")
-            assert response.status_code == 422
-            # assert response.json() == {"detail": "Invalid issue number"}
-        except Exception as e:
-            print(response.status_code)
-            print(f"An error occurred: {e}")
+        response = client.post("/issues/abc/analyze")
+        assert response.status_code == 422
+        # Validate error response structure
+        error_detail = response.json()["detail"]
+        assert isinstance(error_detail, list)
+        assert error_detail[0]["type"] == "int_parsing"
+        assert error_detail[0]["loc"] == ["path", "issue_number"]
 
+    def test_analyze_issue_unauthorized(self, client: TestClient):
         # Test case 3: Unauthorized access
         response = client.post("/issues/456/analyze")
         assert response.status_code == 401
-        assert response.json() == {"detail": "Unauthorized"}
+        assert response.js_on() == {"detail": "Unauthorized"}
 
         # Add more test cases as needed