Skip to content

fix: unwanted overflow in recorder #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

fix: unwanted overflow in recorder #874

wants to merge 9 commits into from
+19 −18

Conversation

@amhsirak
Copy link
Member

@amhsirak amhsirak commented Nov 5, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Style
    • Adjusted browser actions panel positioning and removed its border for a cleaner layout.
    • Made interpretation log drawer height driven by a more responsive preview height for better proportional display.
    • Changed recording page layout to a flex column and disabled inner overflow scrolling for more predictable sizing and presentation.

@coderabbitai
Copy link

coderabbitai bot commented Nov 5, 2025 •
edited
Loading

Warning

Rate limit exceeded

@amhsirak has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 28 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between c878939 and cdee69a.

📒 Files selected for processing (3)
  • src/components/browser/BrowserRecordingSave.tsx (1 hunks)
  • src/pages/PageWrapper.tsx (3 hunks)
  • src/pages/RecordingPage.tsx (1 hunks)

Walkthrough

UI layout and styling adjustments: right-side Paper gets positioning and border tweaks; interpretation log drawer height now uses responsive outputPreviewHeight; recording page inner container switches to a flex column and hides overflow; responsive height multiplier increased.

Changes

Cohort / File(s) Summary
Right-side panel styling
src/components/recorder/RightSidePanel.tsx		 Added position: relative and border: none to the Paper with id browser-actions.
Interpretation log height
src/components/run/InterpretationLog.tsx		 Replaced fixed calc(100% - 140px) drawer/paper height with the outputPreviewHeight value.
Recording page layout
src/pages/RecordingPage.tsx		 Changed inner container from overflow: auto to overflow: hidden and wrapped content in a flex column layout.
Responsive dimensions
src/helpers/dimensionUtils.ts		 Increased outputPreviewHeight calculation from windowHeight * 0.7 to windowHeight * 0.9 in getResponsiveDimensions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Focus review on visual/scrolling behavior across breakpoints and that outputPreviewHeight is applied consistently.

Possibly related PRs

Suggested labels

Type: Bug, Scope: Recorder

Suggested reviewers

  • RohitR311

Poem

🐰 I nudged a border, stretched heights with pride,
Wrapped content in flex so scrolls now bide.
Previews rise taller, panels sit neat,
A rabbit’s small tweak — compact and sweet. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: unwanted overflow in recorder' clearly and directly describes the main change - addressing overflow issues in the recorder component by adjusting layout and sizing behavior.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@amhsirak
Copy link
Member Author

amhsirak commented Nov 5, 2025

@RohitR311 pls confirm if this actually solves the recorder overflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amhsirak