eslint: add rule: prefer-object-has-own (#1698)

`Object.prototype.hasOwnProperty.call(a, b)` now has a simpler equivalent: `Object.hasOwn(a, b)`.

Author: alxndrsn

.eslintrc.json

@@ -44,6 +44,7 @@
     "object-property-newline": "off",
     "operator-linebreak": "off",
     "padded-blocks": "off",
+    "prefer-object-has-own": "error",
     "prefer-object-spread": "off",
     "prefer-template": "off",
     "quotes": [ "error", "single", { "allowTemplateLiterals": true, "avoidEscape": true } ],

lib/data/odk-reporter.js

@@ -27,7 +27,7 @@ const convertObjectToXml = (data) => {
   let output = '';
   if (typeof data === 'object') {
     for (const k in data) {
-      if (Object.prototype.hasOwnProperty.call(data, k)) {
+      if (Object.hasOwn(data, k)) {
         if (Array.isArray(data[k])) {
           // If the data is an array, it is repeat data and
           // the xml should have the outer tag repeated e.g.

lib/data/submission.js

@@ -238,9 +238,9 @@ const _diffObj = (a, b, subpath) => {
   const results = [];
   for (const key of union(a[keys], b[keys])) {
     const av = a[key];
-    if (!Object.prototype.hasOwnProperty.call(a, key)) { // null -> b
+    if (!Object.hasOwn(a, key)) { // null -> b
       results.push({ new: b[key], path: subpath.concat([ stripNamespacesFromPath(key) ]) });
-    } else if (!Object.prototype.hasOwnProperty.call(b, key)) { // a -> null
+    } else if (!Object.hasOwn(b, key)) { // a -> null
       results.push({ old: av, path: subpath.concat([ stripNamespacesFromPath(key) ]) });
     } else if (av[subhash] == null) { // primitive
       if (av !== b[key]) // a -> b

test/e2e/oidc/playwright-tests/playwright.config.js

@@ -22,7 +22,7 @@ const requestedBrowsers = process.env.ODK_PLAYWRIGHT_BROWSERS || 'firefox';
 const projects = requestedBrowsers
   .split(',')
   .map(name => {
-    if (!Object.prototype.hasOwnProperty.call(availableProjects, name)) {
+    if (!Object.hasOwn(availableProjects, name)) {
       throw new Error(`No project config available with name '${name}'!`);
     }
     const use = availableProjects[name];