fixes c#479: update text on expand button on home page (#861)

* fixes c#479: update text on expand button on home page

* pluralise the messages

Author: sadiqkhoja

src/components/project/home-block.vue

@@ -46,10 +46,10 @@ except according to the terms contained in the LICENSE file.
         <td colspan="6" class="expand-button-container">
           <a href="#" role="button" class="expand-button" @click.prevent="toggleDatasetExpanded">
             <template v-if="!datasetExpanded">
-              {{ $tcn('showMore', numDatasets) }}<span class="icon-angle-down"></span>
+              {{ $tcn('showMoreDatasets', numDatasets) }}<span class="icon-angle-down"></span>
             </template>
             <template v-else>
-              {{ $tcn('showFewer', numDatasets) }}<span class="icon-angle-up"></span>
+              {{ $tcn('showFewerDatasets', numDatasets) }}<span class="icon-angle-up"></span>
             </template>
           </a>
         </td>
@@ -262,10 +262,15 @@ export default {
     "encrypted": "Encrypted",
     "encryptionTip": "This Project uses managed encryption.",
     // This clickable text is shown below a table of forms where only a few out of the total number ("count") of forms is shown.
-    "showMore": "Show {count} total",
+    "showMore": "Show {count} total Form | Show {count} total Forms",
+    // This clickable text is shown below a table of entity lists where only a few out of the total number ("count") of entity lists is shown.
+    "showMoreDatasets": "Show {count} total Entity List | Show {count} total Entity Lists",
     // This clickable text is shown below an expanded table of forms that can be collapsed to hide some forms.
     // "Count" refers to the number of forms.
-    "showFewer": "Show fewer of {count} total"
+    "showFewer": "Show fewer of {count} total Form | Show fewer of {count} total Forms",
+    // This clickable text is shown below an expanded table of entity lists that can be collapsed to hide some entity list.
+    // "Count" refers to the number of entity lists.
+    "showFewerDatasets": "Show fewer of {count} total Entity List | Show fewer of {count} total Entity Lists"
   }
 }
 </i18n>

test/components/project/home-block.spec.js

@@ -72,7 +72,7 @@ describe('ProjectHomeBlock', () => {
     block.findAllComponents(FormRow).length.should.equal(3);
     const expand = block.find('.expand-button');
     expand.exists().should.be.true();
-    expand.text().should.equal('Show 4 total');
+    expand.text().should.equal('Show 4 total Forms');
     expand.find('.icon-angle-down').exists().should.be.true();
   });
 
@@ -84,7 +84,7 @@ describe('ProjectHomeBlock', () => {
     const expand = block.find('.expand-button');
     await expand.trigger('click');
     block.findAllComponents(FormRow).length.should.equal(4);
-    expand.text().should.equal('Show fewer of 4 total');
+    expand.text().should.equal('Show fewer of 4 total Forms');
     expand.find('.icon-angle-up').exists().should.be.true();
   });
 
@@ -128,7 +128,7 @@ describe('ProjectHomeBlock', () => {
     const block = mountComponent();
     const expand = block.find('.expand-button');
     expand.exists().should.be.true();
-    expand.text().should.equal('Show 4 total');
+    expand.text().should.equal('Show 4 total Forms');
     await expand.trigger('click');
     const rows = block.findAllComponents(FormRow);
     rows.map((row) => row.props().form.name).should.eql(['a', 'c', 'd', 'e']);
@@ -153,7 +153,7 @@ describe('ProjectHomeBlock', () => {
     block.find('.project-form-row .expand-button').exists().should.be.false();
     const expand = block.find('.project-dataset-row .expand-button');
     expand.exists().should.be.true();
-    expand.text().should.equal('Show 4 total');
+    expand.text().should.equal('Show 4 total Entity Lists');
     expand.find('.icon-angle-down').exists().should.be.true();
     block.find('.margin').exists().should.be.false();
   });
@@ -166,7 +166,7 @@ describe('ProjectHomeBlock', () => {
     const expand = block.find('.project-dataset-row .expand-button');
     await expand.trigger('click');
     block.findAllComponents(DatasetRow).length.should.equal(4);
-    expand.text().should.equal('Show fewer of 4 total');
+    expand.text().should.equal('Show fewer of 4 total Entity Lists');
     expand.find('.icon-angle-up').exists().should.be.true();
   });
 
@@ -192,13 +192,13 @@ describe('ProjectHomeBlock', () => {
     block.findAllComponents(DatasetRow).length.should.equal(3);
     const formExpand = block.find('.project-form-row .expand-button');
     formExpand.exists().should.be.true();
-    formExpand.text().should.equal('Show 5 total');
+    formExpand.text().should.equal('Show 5 total Forms');
     formExpand.find('.icon-angle-down').exists().should.be.true();
 
     block.findAllComponents(FormRow).length.should.equal(3);
     const dsExpand = block.find('.project-dataset-row .expand-button');
     dsExpand.exists().should.be.true();
-    dsExpand.text().should.equal('Show 4 total');
+    dsExpand.text().should.equal('Show 4 total Entity Lists');
     dsExpand.find('.icon-angle-down').exists().should.be.true();
   });
 });

transifex/strings_en.json

@@ -3140,12 +3140,20 @@
         "string": "This Project uses managed encryption."
       },
       "showMore": {
-        "string": "Show {count} total",
+        "string": "{count, plural, one {Show {count} total Form} other {Show {count} total Forms}}",
         "developer_comment": "This clickable text is shown below a table of forms where only a few out of the total number (\"count\") of forms is shown."
       },
+      "showMoreDatasets": {
+        "string": "{count, plural, one {Show {count} total Entity List} other {Show {count} total Entity Lists}}",
+        "developer_comment": "This clickable text is shown below a table of entity lists where only a few out of the total number (\"count\") of entity lists is shown."
+      },
       "showFewer": {
-        "string": "Show fewer of {count} total",
+        "string": "{count, plural, one {Show fewer of {count} total Form} other {Show fewer of {count} total Forms}}",
         "developer_comment": "This clickable text is shown below an expanded table of forms that can be collapsed to hide some forms. \"Count\" refers to the number of forms."
+      },
+      "showFewerDatasets": {
+        "string": "{count, plural, one {Show fewer of {count} total Entity List} other {Show fewer of {count} total Entity Lists}}",
+        "developer_comment": "This clickable text is shown below an expanded table of entity lists that can be collapsed to hide some entity list. \"Count\" refers to the number of entity lists."
       }
     },
     "ProjectList": {