feat(#560): edit coordinates for a vertex or feature #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3478e9e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
latin-panda
commented
Jan 2, 2026
| mapFeatures?.saveFeature(feature); | ||
| // Refresh selected vertex. | ||
| const vertexIndex = feature.get(SELECTED_VERTEX_INDEX_PROPERTY) as number | undefined; | ||
| events.onVertexSelect(getVertexByIndex(feature, vertexIndex)); |
Collaborator
Author
There was a problem hiding this comment.
This refresh updates the status bar and the advanced panel after a vertex is deleted or updated.
Collaborator
Author
|
Testing finished and recorded evidence |
…vertex # Conflicts: # packages/web-forms/tests/components/common/map/createFeatureCollectionAndProps.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #560
I have verified this PR works in these browsers (latest versions):
What else has been done to verify that this works as intended?
Test case: Errors messages in desktop
Test case: Errors messages in mobile
Test case: Full-screen experience
Test case: readonly map
readonly-map.mp4
Test case: geoshape
test-shape.mp4
Test case: geotrace
test-trace.mp4
Regression test: geopoint with "maps" and "placement-map" appearances
geopoint-regression.mp4
Regression test: select with "map" appearance
select-with-map-regression.mp4
Why is this the best possible solution? Were any other approaches considered?
This is an extension of the current feature:
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Do we need any specific form for testing your changes? If so, please attach one.
What's changed
mapHelpers.tsto perform basic validation and return coordinates based on whether the expected feature is a point, line string, or polygon. This is used to return the correct coordinate format after the user pastes a value or uploads a file to overwrite an existing feature.createFeatureCollectionAndProps.tsto geojson-parsers.tsgeojson-parsers.ts