docs: Resolve issues with 'patches'

Two issues:

- Errors are reported as a mapping of the field name to an array of
  errors, not a string.
- We were attempting to validate an invalid request.

Signed-off-by: Stephen Finucane <[email protected]>

Author: stephenfin

docs/api/schemas/latest/patchwork.yaml

@@ -2532,19 +2532,27 @@ components:
       properties:
         state:
           title: State
-          type: string
+          type: array
+          items:
+            type: string
           readOnly: true
         target_url:
           title: Target URL
-          type: string
+          type: array
+          items:
+            type: string
           readOnly: true
         context:
           title: Context
-          type: string
+          type: array
+          items:
+            type: string
           readOnly: true
         description:
           title: Description
-          type: string
+          type: array
+          items:
+            type: string
           readOnly: true
     ErrorPatchUpdate:
       type: object

docs/api/schemas/patchwork.j2

@@ -2634,19 +2634,27 @@ components:
       properties:
         state:
           title: State
-          type: string
+          type: array
+          items:
+            type: string
           readOnly: true
         target_url:
           title: Target URL
-          type: string
+          type: array
+          items:
+            type: string
           readOnly: true
         context:
           title: Context
-          type: string
+          type: array
+          items:
+            type: string
           readOnly: true
         description:
           title: Description
-          type: string
+          type: array
+          items:
+            type: string
           readOnly: true
     ErrorPatchUpdate:
       type: object

docs/api/schemas/v1.0/patchwork.yaml

@@ -2153,19 +2153,27 @@ components:
       properties:
         state:
           title: State
-          type: string
+          type: array
+          items:
+            type: string
           readOnly: true
         target_url:
           title: Target URL
-          type: string
+          type: array
+          items:
+            type: string
           readOnly: true
         context:
           title: Context
-          type: string
+          type: array
+          items:
+            type: string
           readOnly: true
         description:
           title: Description
-          type: string
+          type: array
+          items:
+            type: string
           readOnly: true
     ErrorPatchUpdate:
       type: object

docs/api/schemas/v1.1/patchwork.yaml

@@ -2237,19 +2237,27 @@ components:
       properties:
         state:
           title: State
-          type: string
+          type: array
+          items:
+            type: string
           readOnly: true
         target_url:
           title: Target URL
-          type: string
+          type: array
+          items:
+            type: string
           readOnly: true
         context:
           title: Context
-          type: string
+          type: array
+          items:
+            type: string
           readOnly: true
         description:
           title: Description
-          type: string
+          type: array
+          items:
+            type: string
           readOnly: true
     ErrorPatchUpdate:
       type: object

docs/api/schemas/v1.2/patchwork.yaml

@@ -2532,19 +2532,27 @@ components:
       properties:
         state:
           title: State
-          type: string
+          type: array
+          items:
+            type: string
           readOnly: true
         target_url:
           title: Target URL
-          type: string
+          type: array
+          items:
+            type: string
           readOnly: true
         context:
           title: Context
-          type: string
+          type: array
+          items:
+            type: string
           readOnly: true
         description:
           title: Description
-          type: string
+          type: array
+          items:
+            type: string
           readOnly: true
     ErrorPatchUpdate:
       type: object

patchwork/tests/api/test_check.py

@@ -147,7 +147,7 @@ def test_create_invalid_state(self):
         }
 
         self.client.force_authenticate(user=self.user)
-        resp = self.client.post(self.api_url(), check)
+        resp = self.client.post(self.api_url(), check, validate_request=False)
         self.assertEqual(status.HTTP_400_BAD_REQUEST, resp.status_code)
         self.assertEqual(0, Check.objects.all().count())
 
@@ -164,7 +164,7 @@ def test_create_missing_state(self):
         }
 
         self.client.force_authenticate(user=self.user)
-        resp = self.client.post(self.api_url(), check)
+        resp = self.client.post(self.api_url(), check, validate_request=False)
         self.assertEqual(status.HTTP_400_BAD_REQUEST, resp.status_code)
         self.assertEqual(0, Check.objects.all().count())