CLI: Substitutions not substituted everywhere

[bertbesser]

My goal is to use a substitutions for container labels, like e.g.

steps:
  - id: some-id
    uses: some-image
    options:
      labels:
        sample-label: $_POPPER_SUBST_LABEL
    args: some-args

However, popper does substitutions only within top-level keys of each step (e.g. id) and top-level dicts (e.g. env), but not further down the yaml tree.

Observed behavior

popper run -f the-above-wf.yml --substitution _POPPER_SUBST_LABEL=this-should-appear results in

steps:
  - id: some-id
    uses: some-image
    options:
      labels:
        sample-label: $_POPPER_SUBST_LABEL
    args: some-args

instead of the expected output.

Expected behavior

steps:
  - id: some-id
    uses: some-image
    options:
      labels:
        sample-label: this-should-appear
    args: some-args

[bertbesser]

For reference, the documentation suggests that substitutions apply globally: link to doc.

Here's a link to the code.

[bertbesser]

#967 Solves this issue.