Skip to content

Commit 0b5907f

Browse files
Fix css height for mobile safari not to overlap URL bar (#7334)
1 parent 00a97d9 commit 0b5907f

File tree

6 files changed

+14
-10
lines changed

6 files changed

+14
-10
lines changed

client/app/assets/css/login.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ body {
1515
display: table;
1616
width: 100%;
1717
padding: 10px;
18-
height: calc(100vh - 116px);
18+
height: calc(100% - 116px);
1919
}
2020

2121
@media (min-width: 992px) {

client/app/assets/less/inc/base.less

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ html {
2020

2121
html,
2222
body {
23-
min-height: 100vh;
23+
height: 100%;
2424
}
2525

2626
body {
@@ -35,7 +35,7 @@ body {
3535
}
3636

3737
#application-root {
38-
min-height: 100vh;
38+
height: 100%;
3939
}
4040

4141
#application-root,

client/app/assets/less/inc/login.less

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
vertical-align: middle;
1111
display: inline-block;
1212
width: 1px;
13-
height: 100vh;
13+
height: 100%;
1414
}
1515
}
1616

@@ -135,4 +135,4 @@
135135

136136
}
137137
}
138-
138+

client/app/assets/less/redash/query.less

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ body.fixed-layout {
88
padding-bottom: 0;
99

1010
width: 100vw;
11-
height: 100vh;
11+
height: 100%;
1212

1313
.application-layout-content > div {
1414
display: flex;
@@ -90,7 +90,7 @@ body.fixed-layout {
9090
.embed__vis {
9191
display: flex;
9292
flex-flow: column;
93-
height: calc(~'100vh - 25px');
93+
height: calc(~'100% - 25px');
9494

9595
> .embed-heading {
9696
flex: 0 0 auto;

client/app/components/ApplicationArea/ApplicationLayout/index.less

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ body #application-root {
77
flex-direction: row;
88
justify-content: stretch;
99
padding-bottom: 0 !important;
10-
height: 100vh;
10+
height: 100%;
1111

1212
.application-layout-side-menu {
13-
height: 100vh;
13+
height: 100%;
1414
position: relative;
1515

1616
@media @mobileBreakpoint {
@@ -47,6 +47,10 @@ body #application-root {
4747
}
4848
}
4949

50+
body > section {
51+
height: 100%;
52+
}
53+
5054
body.fixed-layout #application-root {
5155
.application-layout-content {
5256
padding-bottom: 0;

client/app/pages/dashboards/PublicDashboardPage.less

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
}
99

1010
> .container {
11-
min-height: calc(100vh - 95px);
11+
min-height: calc(100% - 95px);
1212
}
1313

1414
.loading-message {

0 commit comments

Comments
 (0)