Skip to content

Commit d6dbc64

Browse files
authored
bug fix SAML_LOGIN_ENABLED setting logic (#5784)
1 parent 82361e7 commit d6dbc64

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

redash/settings/organization.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@
2121
SAML_SSO_URL = os.environ.get("REDASH_SAML_SSO_URL", "")
2222
SAML_X509_CERT = os.environ.get("REDASH_SAML_X509_CERT", "")
2323
SAML_SP_SETTINGS = os.environ.get("REDASH_SAML_SP_SETTINGS", "")
24-
SAML_LOGIN_ENABLED = SAML_SSO_URL != "" and SAML_METADATA_URL != ""
24+
if SAML_LOGIN_TYPE == "static":
25+
SAML_LOGIN_ENABLED = SAML_SSO_URL != "" and SAML_METADATA_URL != ""
26+
else:
27+
SAML_LOGIN_ENABLED = SAML_METADATA_URL != ""
2528

2629
DATE_FORMAT = os.environ.get("REDASH_DATE_FORMAT", "DD/MM/YY")
2730
TIME_FORMAT = os.environ.get("REDASH_TIME_FORMAT", "HH:mm")

0 commit comments

Comments
 (0)