Commit 15c9230
fix(dashboard): address PR review comments on widget edit
1. Fix stale `fields` in mergeQueries — destructure to omit existing
`fields` so prepareWidgetQueries recomputes from updated aggregates/
columns (bugbot comment #1)
2. Preserve widgetType without silent default — only set widgetType if
explicitly provided via --dataset or already on the existing widget,
preventing parseWidgetInput from defaulting to "spans" (bugbot #4)
3. Resolve aliases in paren passthrough — `spm()` now correctly resolves
to `epm()` instead of being rejected by validation (bugbot #3)
Comment #2 (drops interval/thresholds) is not a real issue — these fields
are already stripped by the allowlist in stripWidgetServerFields before
buildReplacement sees them.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 753f145 commit 15c9230
2 files changed
+15
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
66 | 69 | | |
67 | 70 | | |
68 | | - | |
| 71 | + | |
69 | 72 | | |
70 | 73 | | |
71 | 74 | | |
| |||
81 | 84 | | |
82 | 85 | | |
83 | 86 | | |
84 | | - | |
85 | 87 | | |
86 | 88 | | |
87 | 89 | | |
| |||
90 | 92 | | |
91 | 93 | | |
92 | 94 | | |
93 | | - | |
94 | | - | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
95 | 101 | | |
96 | 102 | | |
97 | 103 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
356 | 356 | | |
357 | 357 | | |
358 | 358 | | |
359 | | - | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
360 | 364 | | |
361 | 365 | | |
362 | 366 | | |
| |||
0 commit comments