Commit 299b509
authored
fix(changelog-preview): Replace deleted install sub-action with inline install (#706)
## Problem
PR #705 removed the `install/` sub-action, but the
`changelog-preview.yml` workflow was still referencing it:
```yaml
uses: getsentry/craft/install@master
```
This broke the changelog preview workflow for all PRs.
## Solution
Replace the deleted sub-action reference with inline install logic that
downloads Craft from release:
- Respects `craft-version` input (defaults to latest)
- Falls back to latest if specified version doesn't exist
- Adds robust error handling with `set -euo pipefail`
- Verifies download succeeded and binary is valid
- Runs `craft --version` to confirm installation
## Why No Dogfooding?
Unlike the main release action, this workflow **does not dogfood** (use
build artifacts from PRs) because:
1. **Different workflow runs**: The build workflow runs separately, and
artifacts are scoped to that workflow run
2. **Complexity**: Cross-workflow artifact fetching would require
additional dependencies and logic
3. **Timing issues**: Build workflow might still be running when
changelog-preview starts
4. **Lower criticality**: Changelog preview is less critical than the
main release action
For changelog previews, we always use the released version of Craft.1 parent ed9bce6 commit 299b509
1 file changed
+45
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
56 | 61 | | |
57 | | - | |
58 | | - | |
59 | | - | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
60 | 101 | | |
61 | 102 | | |
62 | 103 | | |
| |||
0 commit comments