ci: Add TypeScript type checking to CI (#747)

## Summary

- Fix all 215 TypeScript type errors across the codebase
- Add `pnpm typecheck` step to the lint CI workflow
- Enable incremental TypeScript compilation for faster CI runs
- Fix all ESLint warnings

## Changes

**Dependencies:**
- Added `@types/semver` and `tslib` dev dependencies

**Type Fixes:**
- Added `TypedTargetConfig<T>` utility type for strongly-typed target
configs
- Fixed type issues in 16 target files, utilities, and ~40 test files
- Cleaned up unused imports across the test suite

**CI:**
- Added type checking step before lint in `.github/workflows/lint.yml`
- Enabled incremental TS compilation with `.tsbuildinfo` caching

**Lint:**
- Removed unused eslint-disable directives
- Modernized catch blocks to use `catch {}` pattern
- Fixed type-only class exports in mustache.d.ts

Author: BYK

.github/workflows/lint.yml

@@ -28,9 +28,12 @@ jobs:
           path: |
             node_modules
             .eslintcache
+            .tsbuildinfo
           key: ${{ runner.os }}-${{ hashFiles('package.json', 'pnpm-lock.yaml') }}
       - name: Install Dependencies
         if: steps.cache.outputs.cache-hit != 'true'
         run: pnpm install --frozen-lockfile
+      - name: Type Check
+        run: pnpm typecheck
       - name: Lint
         run: pnpm lint -f github-annotations

.gitignore

@@ -16,4 +16,5 @@ npm-debug.log
 .Trashes
 *.env
 .eslintcache
+.tsbuildinfo
 .idea

eslint.config.mjs

@@ -4,7 +4,14 @@ import prettier from 'eslint-config-prettier';
 
 export default tseslint.config(
   {
-    ignores: ['docs/**', 'dist/**', 'node_modules/**', 'coverage/**', '*.mjs', '**/*.js'],
+    ignores: [
+      'docs/**',
+      'dist/**',
+      'node_modules/**',
+      'coverage/**',
+      '*.mjs',
+      '**/*.js',
+    ],
   },
   eslint.configs.recommended,
   ...tseslint.configs.recommended,
@@ -18,7 +25,10 @@ export default tseslint.config(
       '@typescript-eslint/no-explicit-any': 'off',
       'no-constant-condition': ['error', { checkLoops: false }],
       // Make sure variables marked with _ are ignored (ex. _varName)
-      '@typescript-eslint/no-unused-vars': ['warn', { argsIgnorePattern: '^_' }],
+      '@typescript-eslint/no-unused-vars': [
+        'warn',
+        { argsIgnorePattern: '^_' },
+      ],
       '@typescript-eslint/ban-ts-comment': [
         'error',
         {
@@ -47,5 +57,5 @@ export default tseslint.config(
         },
       ],
     },
-  }
+  },
 );

package.json

@@ -33,6 +33,7 @@
     "@types/ora": "^1.3.4",
     "@types/prompts": "^2.0.11",
     "@types/rimraf": "^2.0.2",
+    "@types/semver": "^7.7.1",
     "@types/shell-quote": "^1.6.0",
     "@types/tar": "^4.0.0",
     "@types/tmp": "^0.0.33",
@@ -68,6 +69,7 @@
     "string-length": "3.1.0",
     "tar": "7.5.7",
     "tmp": "0.2.4",
+    "tslib": "^2.8.1",
     "typescript": "^5.7.2",
     "typescript-eslint": "^8.18.2",
     "vitest": "^3.0.2",

pnpm-lock.yaml

@@ -1,7 +1,6 @@
 import { vi } from 'vitest';
 
 // Import the actual fs module using require to avoid circular mock issues
-// eslint-disable-next-line @typescript-eslint/no-require-imports
 const actualFs = require('fs') as typeof import('fs');
 
 // Mock existsSync to return true by default
@@ -104,4 +103,4 @@ export const readv = actualFs.readv;
 export default {
   ...actualFs,
   existsSync,
-};
+} as typeof actualFs;

src/__mocks__/fs.ts

@@ -13,7 +13,6 @@ import { resolve, join } from 'path';
 import { mkdtemp, rm, writeFile, readFile, mkdir, chmod } from 'fs/promises';
 import { existsSync } from 'fs';
 import { tmpdir } from 'os';
-// eslint-disable-next-line no-restricted-imports, no-restricted-syntax -- Test file needs direct git access for setup/verification
 import simpleGit from 'simple-git';
 
 const execFileAsync = promisify(execFile);

src/__tests__/prepare-dry-run.e2e.test.ts

@@ -1,4 +1,3 @@
-import { vi, type Mock, type MockInstance, type Mocked, type MockedFunction } from 'vitest';
 import { parseFilterOptions, RawFilterOptions } from '../base';
 
 describe('parseFilterOptions', () => {
@@ -29,12 +28,12 @@ describe('parseFilterOptions', () => {
       const parsedFilters = parseFilterOptions(rawFilters);
 
       expect(parsedFilters.includeNames).toStrictEqual(
-        includeNames && /include/
+        includeNames && /include/,
       );
 
       expect(parsedFilters.excludeNames).toStrictEqual(
-        excludeNames && /exclude/
+        excludeNames && /exclude/,
       );
-    }
+    },
   );
 });

src/artifact_providers/__tests__/base.test.ts

@@ -1,5 +1,4 @@
 import { vi, describe, test, expect, beforeEach, type Mock } from 'vitest';
-import { join as pathJoin } from 'path';
 import { spawnProcess } from '../../utils/system';
 import { runPreReleaseCommand, checkVersionOrPart } from '../prepare';
 
@@ -34,7 +33,7 @@ describe('runPreReleaseCommand', () => {
           CRAFT_NEW_VERSION: newVersion,
           CRAFT_OLD_VERSION: oldVersion,
         },
-      }
+      },
     );
   });
 
@@ -57,7 +56,7 @@ describe('runPreReleaseCommand', () => {
           CRAFT_NEW_VERSION: newVersion,
           CRAFT_OLD_VERSION: oldVersion,
         },
-      }
+      },
     );
   });
 });
@@ -71,8 +70,8 @@ describe('checkVersionOrPart', () => {
           {
             newVersion: v,
           },
-          null
-        )
+          null,
+        ),
       ).toBe(true);
     }
   });
@@ -83,8 +82,8 @@ describe('checkVersionOrPart', () => {
         {
           newVersion: 'auto',
         },
-        null
-      )
+        null,
+      ),
     ).toBe(true);
   });
 
@@ -96,8 +95,8 @@ describe('checkVersionOrPart', () => {
           {
             newVersion: bumpType,
           },
-          null
-        )
+          null,
+        ),
       ).toBe(true);
     }
   });
@@ -110,8 +109,7 @@ describe('checkVersionOrPart', () => {
       },
       {
         v: 'v2.3.3',
-        e:
-          'Invalid version or version part specified: "v2.3.3". Removing the "v" prefix will likely fix the issue',
+        e: 'Invalid version or version part specified: "v2.3.3". Removing the "v" prefix will likely fix the issue',
       },
     ];
     for (const t of invalidVersions) {
@@ -120,7 +118,7 @@ describe('checkVersionOrPart', () => {
           {
             newVersion: t.v,
           },
-          null
+          null,
         );
       };
       expect(fn).toThrow(t.e);

src/commands/__tests__/prepare.test.ts

@@ -637,7 +637,9 @@ export async function publishMain(argv: PublishOptions): Promise<any> {
     // finishes then as nothing relies on the removal of this file.
     safeFs
       .unlink(publishStateFile)
-      .catch(err => logger.trace("Couldn't remove publish state file: ", err));
+      .catch((err: unknown) =>
+        logger.trace("Couldn't remove publish state file: ", err),
+      );
     logger.success(`Version ${newVersion} has been published!`);
   } else {
     const msg = [