Skip to content

Commit 79a91fe

Browse files
authored
fix: hide the ObjectiveC ARC compile options in the interface library (#134)
1 parent aa6419a commit 79a91fe

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

CMakeLists.txt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,14 @@ if(LINUX)
154154
)
155155
endif()
156156

157+
if(APPLE)
158+
target_compile_options(crashpad_interface INTERFACE
159+
"-fobjc-arc"
160+
"-fno-objc-arc-exceptions"
161+
"-Wno-deprecated-declarations"
162+
)
163+
endif()
164+
157165
add_library(crashpad::interface ALIAS crashpad_interface)
158166

159167
add_subdirectory(compat)

third_party/mini_chromium/CMakeLists.txt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -145,12 +145,6 @@ else()
145145
)
146146
endif()
147147

148-
if(APPLE)
149-
target_compile_options(mini_chromium
150-
PUBLIC "-fobjc-arc" "-fno-objc-arc-exceptions"
151-
PRIVATE "-Wno-deprecated-declarations"
152-
)
153-
endif()
154148
if(APPLE AND NOT IOS)
155149
target_link_libraries(mini_chromium PUBLIC
156150
"-framework ApplicationServices"

util/CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -529,8 +529,6 @@ if(APPLE)
529529
"-framework UIKit"
530530
)
531531
endif()
532-
533-
target_compile_options(crashpad_util PRIVATE "-Wno-deprecated-declarations")
534532
endif()
535533

536534
if(LINUX)

0 commit comments

Comments
 (0)