refactor: improve danger workflow test readability and maintainability

Apply same cleanup principles to danger-workflow-tests.yml:

✨ Improvements:
- Move assertion to same job as action execution
- Clear job name describing test purpose
- Replace cryptic one-liner with readable validation logic
- Add informative error messages with debugging hints
- Use environment variables for better readability
- Remove unnecessary job dependencies

🎯 Benefits:
- Faster feedback on test failures
- Self-contained test that's easier to understand
- Better error messages explaining what might be wrong
- Consistent structure with updater workflow tests

The test now clearly validates that Danger runs successfully on PRs
and provides helpful debugging information when it fails.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: vaind

.github/workflows/danger-workflow-tests.yml

@@ -11,18 +11,33 @@ permissions:
   issues: write
 
 jobs:
-  danger:
+  # Test Danger action on pull requests - should analyze PR and report findings
+  test-danger-pr-analysis:
     runs-on: ubuntu-latest
-    outputs:
-      outcome: ${{ steps.danger.outputs.outcome }}
     steps:
-      - uses: actions/checkout@v4
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
       - name: Run danger action
         id: danger
         uses: ./danger
 
-  test-outputs:
-    runs-on: ubuntu-latest
-    needs: danger
-    steps:
-      - run: "[[ '${{ needs.danger.outputs.outcome }}' == 'success' ]]"
+      - name: Validate danger outputs
+        env:
+          DANGER_OUTCOME: ${{ steps.danger.outputs.outcome }}
+        run: |
+          echo "🔍 Validating Danger action outputs..."
+          echo "Danger Outcome: '$DANGER_OUTCOME'"
+
+          # Validate that Danger ran successfully
+          if [[ "$DANGER_OUTCOME" != "success" ]]; then
+            echo "❌ Expected Danger outcome 'success', got '$DANGER_OUTCOME'"
+            echo "This could indicate:"
+            echo "  - Danger found issues that caused it to fail"
+            echo "  - The action itself encountered an error"
+            echo "  - Docker container issues"
+            exit 1
+          fi
+
+          echo "✅ Danger PR analysis completed successfully!"
+          echo "ℹ️  Check the PR comments for any Danger findings"

.github/workflows/workflow-tests.yml

@@ -13,17 +13,11 @@ jobs:
   # Test PR creation scenario - should create a PR with specific version pattern
   test-updater-pr-creation:
     runs-on: ubuntu-latest
-    outputs:
-      prUrl: ${{ steps.updater.outputs.prUrl }}
-      baseBranch: ${{ steps.updater.outputs.baseBranch }}
-      prBranch: ${{ steps.updater.outputs.prBranch }}
-      originalTag: ${{ steps.updater.outputs.originalTag }}
-      latestTag: ${{ steps.updater.outputs.latestTag }}
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
 
-      - name: Test updater - PR creation scenario
+      - name: Run updater action
         id: updater
         uses: ./updater
         with:
@@ -33,41 +27,13 @@ jobs:
           pr-strategy: update
           api-token: ${{ github.token }}
 
-  # Test no-change scenario - should detect no updates needed
-  test-updater-no-changes:
-    runs-on: macos-latest
-    outputs:
-      prUrl: ${{ steps.updater.outputs.prUrl }}
-      baseBranch: ${{ steps.updater.outputs.baseBranch }}
-      prBranch: ${{ steps.updater.outputs.prBranch }}
-      originalTag: ${{ steps.updater.outputs.originalTag }}
-      latestTag: ${{ steps.updater.outputs.latestTag }}
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-
-      - name: Test updater - no changes scenario
-        id: updater
-        uses: ./updater
-        with:
-          path: updater/tests/workflow-args.sh
-          name: Workflow args test script
-          pattern: '.*'
-          api-token: ${{ github.token }}
-
-  validate-test-outputs:
-    runs-on: ubuntu-latest
-    needs:
-      - test-updater-pr-creation
-      - test-updater-no-changes
-    steps:
-      - name: Validate PR creation scenario outputs
+      - name: Validate PR creation outputs
         env:
-          BASE_BRANCH: ${{ needs.test-updater-pr-creation.outputs.baseBranch }}
-          ORIGINAL_TAG: ${{ needs.test-updater-pr-creation.outputs.originalTag }}
-          LATEST_TAG: ${{ needs.test-updater-pr-creation.outputs.latestTag }}
-          PR_URL: ${{ needs.test-updater-pr-creation.outputs.prUrl }}
-          PR_BRANCH: ${{ needs.test-updater-pr-creation.outputs.prBranch }}
+          BASE_BRANCH: ${{ steps.updater.outputs.baseBranch }}
+          ORIGINAL_TAG: ${{ steps.updater.outputs.originalTag }}
+          LATEST_TAG: ${{ steps.updater.outputs.latestTag }}
+          PR_URL: ${{ steps.updater.outputs.prUrl }}
+          PR_BRANCH: ${{ steps.updater.outputs.prBranch }}
         run: |
           echo "🔍 Validating PR creation scenario outputs..."
           echo "Base Branch: '$BASE_BRANCH'"
@@ -108,13 +74,29 @@ jobs:
 
           echo "✅ PR creation scenario validation passed!"
 
-      - name: Validate no-changes scenario outputs
+  # Test no-change scenario - should detect no updates needed
+  test-updater-no-changes:
+    runs-on: macos-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Run updater action
+        id: updater
+        uses: ./updater
+        with:
+          path: updater/tests/workflow-args.sh
+          name: Workflow args test script
+          pattern: '.*'
+          api-token: ${{ github.token }}
+
+      - name: Validate no-changes outputs
         env:
-          BASE_BRANCH: ${{ needs.test-updater-no-changes.outputs.baseBranch }}
-          ORIGINAL_TAG: ${{ needs.test-updater-no-changes.outputs.originalTag }}
-          LATEST_TAG: ${{ needs.test-updater-no-changes.outputs.latestTag }}
-          PR_URL: ${{ needs.test-updater-no-changes.outputs.prUrl }}
-          PR_BRANCH: ${{ needs.test-updater-no-changes.outputs.prBranch }}
+          BASE_BRANCH: ${{ steps.updater.outputs.baseBranch }}
+          ORIGINAL_TAG: ${{ steps.updater.outputs.originalTag }}
+          LATEST_TAG: ${{ steps.updater.outputs.latestTag }}
+          PR_URL: ${{ steps.updater.outputs.prUrl }}
+          PR_BRANCH: ${{ steps.updater.outputs.prBranch }}
         run: |
           echo "🔍 Validating no-changes scenario outputs..."
           echo "Base Branch: '$BASE_BRANCH'"