Skip to content

Commit 6af183f

Browse files
authored
fix: accept chunked ProGuard uploads (#140)
1 parent 010a398 commit 6af183f

File tree

3 files changed

+19
-1
lines changed

3 files changed

+19
-1
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Changelog
22

3+
## Unreleased
4+
5+
### Fixes
6+
7+
- Sentry-CLI integration test action - Accept chunked ProGuard uploads for compatibility with Sentry CLI 3.x ([#140](https://github.com/getsentry/github-workflows/pull/140))
8+
39
## 3.2.0
410

511
### Features

sentry-cli/integration-test/sentry-server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def do_GET(self):
4343
self.writeJSON('{"url":"' + uri.geturl() + self.path + '",'
4444
'"chunkSize":8388608,"chunksPerRequest":64,"maxFileSize":2147483648,'
4545
'"maxRequestSize":33554432,"concurrency":1,"hashAlgorithm":"sha1","compression":["gzip"],'
46-
'"accept":["debug_files","release_files","pdbs","sources","bcsymbolmaps","il2cpp","portablepdbs"]}')
46+
'"accept":["debug_files","release_files","pdbs","sources","bcsymbolmaps","il2cpp","portablepdbs","proguard"]}')
4747
elif self.isApi('/api/0/organizations/{}/repos/?cursor='.format(apiOrg)):
4848
self.writeJSONFile("assets/repos.json")
4949
elif self.isApi('/api/0/organizations/{}/releases/{}@{}/previous-with-commits/'.format(apiOrg, appIdentifier, version)):

sentry-cli/integration-test/tests/action.Tests.ps1

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,18 @@ Describe 'Invoke-SentryServer' {
4343
$result.UploadedDebugFiles() | Should -Be @('file3.dylib', 'file2.so', 'file1.dll')
4444
}
4545

46+
It "accepts chunked uploads" {
47+
$result = Invoke-SentryServer {
48+
param([string]$url)
49+
$response = Invoke-WebRequest -Uri "$url/api/0/organizations/org/chunk-upload/"
50+
$json = $response.Content | ConvertFrom-Json
51+
@("debug_files", "pdbs", "sources", "portablepdbs", "proguard") | ForEach-Object {
52+
$json.accept | Should -Contain $_
53+
}
54+
}
55+
Should -ActualValue $result.HasErrors() -BeFalse
56+
}
57+
4658
It "collects proguard mapping" {
4759
$result = Invoke-SentryServer {
4860
Param([string]$url)

0 commit comments

Comments
 (0)