refactor: Improve test structure with shared data and individual cases

- Move test data creation to Context BeforeAll level
- Restore individual test cases (16 total) for focused testing
- Eliminate data duplication while keeping inline visibility
- Best of both worlds: shared setup + granular test cases

Structure:
- Context BeforeAll: Creates shared test files with inline data
- Individual It blocks: Reference shared files for specific scenarios
- Clear test names and focused assertions per test case

Author: vaind

updater/tests/update-dependency-cmake.Tests.ps1

@@ -5,14 +5,12 @@ BeforeAll {
 
 Describe 'CMake Helper Functions' {
     Context 'Parse-CMakeFetchContent' {
-        BeforeEach {
+        BeforeAll {
             $script:tempDir = "$TestDrive/cmake-tests"
             New-Item $tempDir -ItemType Directory -Force | Out-Null
-        }
 
-        It 'parses FetchContent_Declare with various scenarios' {
-            # Test 1: Basic parsing with explicit dependency name
-            $testFile1 = "$tempDir/basic.cmake"
+            # Create test files with inline data
+            $script:basicFile = "$tempDir/basic.cmake"
             @'
 include(FetchContent)
 
@@ -24,21 +22,9 @@ FetchContent_Declare(
 )
 
 FetchContent_MakeAvailable(sentry-native)
-'@ | Out-File $testFile1
+'@ | Out-File $basicFile
 
-            $result = Parse-CMakeFetchContent $testFile1 'sentry-native'
-            $result.GitRepository | Should -Be 'https://github.com/getsentry/sentry-native'
-            $result.GitTag | Should -Be 'v0.9.1'
-            $result.DepName | Should -Be 'sentry-native'
-
-            # Test 2: Auto-detection with same file
-            $result = Parse-CMakeFetchContent $testFile1 $null
-            $result.GitRepository | Should -Be 'https://github.com/getsentry/sentry-native'
-            $result.GitTag | Should -Be 'v0.9.1'
-            $result.DepName | Should -Be 'sentry-native'
-
-            # Test 3: Hash values
-            $testFile2 = "$tempDir/hash.cmake"
+            $script:hashFile = "$tempDir/hash.cmake"
             @'
 include(FetchContent)
 
@@ -51,15 +37,9 @@ FetchContent_Declare(
 )
 
 FetchContent_MakeAvailable(sentry-native)
-'@ | Out-File $testFile2
-
-            $result = Parse-CMakeFetchContent $testFile2 'sentry-native'
-            $result.GitRepository | Should -Be 'https://github.com/getsentry/sentry-native'
-            $result.GitTag | Should -Be 'a64d5bd8ee130f2cda196b6fa7d9b65bfa6d32e2'
-            $result.DepName | Should -Be 'sentry-native'
+'@ | Out-File $hashFile
 
-            # Test 4: Complex multi-line formatting
-            $testFile3 = "$tempDir/complex.cmake"
+            $script:complexFile = "$tempDir/complex.cmake"
             @'
 include(FetchContent)
 
@@ -76,16 +56,9 @@ FetchContent_Declare(
 )
 
 FetchContent_MakeAvailable(sentry-native)
-'@ | Out-File $testFile3
+'@ | Out-File $complexFile
 
-            $result = Parse-CMakeFetchContent $testFile3 'sentry-native'
-            $result.GitRepository | Should -Be 'https://github.com/getsentry/sentry-native'
-            $result.GitTag | Should -Be 'v0.9.1'
-            $result.DepName | Should -Be 'sentry-native'
-        }
-
-        It 'handles multiple dependencies correctly' {
-            $testFile = "$tempDir/multiple.cmake"
+            $script:multipleFile = "$tempDir/multiple.cmake"
             @'
 include(FetchContent)
 
@@ -102,76 +75,104 @@ FetchContent_Declare(
 )
 
 FetchContent_MakeAvailable(sentry-native googletest)
-'@ | Out-File $testFile
-
-            # Should throw when no explicit name given
-            { Parse-CMakeFetchContent $testFile $null } | Should -Throw '*Multiple FetchContent declarations found*'
-
-            # Should work with explicit dependency name
-            $result = Parse-CMakeFetchContent $testFile 'googletest'
-            $result.GitRepository | Should -Be 'https://github.com/google/googletest'
-            $result.GitTag | Should -Be 'v1.14.0'
-            $result.DepName | Should -Be 'googletest'
-        }
+'@ | Out-File $multipleFile
 
-        It 'throws appropriate errors for invalid scenarios' {
-            # Test 1: Missing dependency
-            $testFile1 = "$tempDir/valid.cmake"
+            $script:missingRepoFile = "$tempDir/missing-repo.cmake"
             @'
 include(FetchContent)
 
 FetchContent_Declare(
     sentry-native
-    GIT_REPOSITORY https://github.com/getsentry/sentry-native
     GIT_TAG v0.9.1
 )
-'@ | Out-File $testFile1
-
-            { Parse-CMakeFetchContent $testFile1 'nonexistent' } | Should -Throw "*FetchContent_Declare for 'nonexistent' not found*"
+'@ | Out-File $missingRepoFile
 
-            # Test 2: Missing GIT_REPOSITORY
-            $testFile2 = "$tempDir/missing-repo.cmake"
+            $script:missingTagFile = "$tempDir/missing-tag.cmake"
             @'
 include(FetchContent)
 
 FetchContent_Declare(
     sentry-native
-    GIT_TAG v0.9.1
+    GIT_REPOSITORY https://github.com/getsentry/sentry-native
 )
-'@ | Out-File $testFile2
+'@ | Out-File $missingTagFile
+        }
 
-            { Parse-CMakeFetchContent $testFile2 'sentry-native' } | Should -Throw '*Could not parse GIT_REPOSITORY or GIT_TAG*'
+        It 'parses basic FetchContent_Declare with explicit dependency name' {
+            $result = Parse-CMakeFetchContent $basicFile 'sentry-native'
 
-            # Test 3: Missing GIT_TAG
-            $testFile3 = "$tempDir/missing-tag.cmake"
-            @'
-include(FetchContent)
+            $result.GitRepository | Should -Be 'https://github.com/getsentry/sentry-native'
+            $result.GitTag | Should -Be 'v0.9.1'
+            $result.DepName | Should -Be 'sentry-native'
+        }
 
-FetchContent_Declare(
-    sentry-native
-    GIT_REPOSITORY https://github.com/getsentry/sentry-native
-)
-'@ | Out-File $testFile3
+        It 'auto-detects single FetchContent_Declare' {
+            $result = Parse-CMakeFetchContent $basicFile $null
 
-            { Parse-CMakeFetchContent $testFile3 'sentry-native' } | Should -Throw '*Could not parse GIT_REPOSITORY or GIT_TAG*'
+            $result.GitRepository | Should -Be 'https://github.com/getsentry/sentry-native'
+            $result.GitTag | Should -Be 'v0.9.1'
+            $result.DepName | Should -Be 'sentry-native'
+        }
+
+        It 'handles hash values correctly' {
+            $result = Parse-CMakeFetchContent $hashFile 'sentry-native'
+
+            $result.GitRepository | Should -Be 'https://github.com/getsentry/sentry-native'
+            $result.GitTag | Should -Be 'a64d5bd8ee130f2cda196b6fa7d9b65bfa6d32e2'
+            $result.DepName | Should -Be 'sentry-native'
+        }
+
+        It 'handles complex multi-line formatting' {
+            $result = Parse-CMakeFetchContent $complexFile 'sentry-native'
+
+            $result.GitRepository | Should -Be 'https://github.com/getsentry/sentry-native'
+            $result.GitTag | Should -Be 'v0.9.1'
+            $result.DepName | Should -Be 'sentry-native'
+        }
+
+        It 'throws on multiple dependencies without explicit name' {
+            { Parse-CMakeFetchContent $multipleFile $null } | Should -Throw '*Multiple FetchContent declarations found*'
+        }
+
+        It 'handles specific dependency from multiple dependencies' {
+            $result = Parse-CMakeFetchContent $multipleFile 'googletest'
+
+            $result.GitRepository | Should -Be 'https://github.com/google/googletest'
+            $result.GitTag | Should -Be 'v1.14.0'
+            $result.DepName | Should -Be 'googletest'
+        }
+
+        It 'throws on missing dependency' {
+            { Parse-CMakeFetchContent $basicFile 'nonexistent' } | Should -Throw "*FetchContent_Declare for 'nonexistent' not found*"
+        }
+
+        It 'throws on missing GIT_REPOSITORY' {
+            { Parse-CMakeFetchContent $missingRepoFile 'sentry-native' } | Should -Throw '*Could not parse GIT_REPOSITORY or GIT_TAG*'
+        }
+
+        It 'throws on missing GIT_TAG' {
+            { Parse-CMakeFetchContent $missingTagFile 'sentry-native' } | Should -Throw '*Could not parse GIT_REPOSITORY or GIT_TAG*'
         }
     }
 
     Context 'Find-TagForHash' {
-        It 'handles hash resolution scenarios' {
-            # Test 1: Hash without matching tag
+        It 'returns null for hash without matching tag' {
+            # Use a fake hash that won't match any real tag
             $fakeHash = 'abcdef1234567890abcdef1234567890abcdef12'
             $repo = 'https://github.com/getsentry/sentry-native'
 
             $result = Find-TagForHash $repo $fakeHash
+
             $result | Should -BeNullOrEmpty
+        }
 
-            # Test 2: Network failures
+        It 'handles network failures gracefully' {
             $invalidRepo = 'https://github.com/nonexistent/repo'
             $hash = 'abcdef1234567890abcdef1234567890abcdef12'
 
             # Should not throw, but return null and show warning
             $result = Find-TagForHash $invalidRepo $hash
+
             $result | Should -BeNullOrEmpty
         }
 
@@ -180,15 +181,12 @@ FetchContent_Declare(
     }
 
     Context 'Update-CMakeFile' {
-        BeforeEach {
-            $script:tempDir = "$TestDrive/cmake-tests"
+        BeforeAll {
+            $script:tempDir = "$TestDrive/cmake-update-tests"
             New-Item $tempDir -ItemType Directory -Force | Out-Null
-        }
 
-        It 'updates CMake files preserving format and structure' {
-            # Test 1: Tag to tag update
-            $testFile1 = "$tempDir/tag-update.cmake"
-            @'
+            # Template for basic CMake file
+            $script:basicTemplate = @'
 include(FetchContent)
 
 FetchContent_Declare(
@@ -199,22 +197,10 @@ FetchContent_Declare(
 )
 
 FetchContent_MakeAvailable(sentry-native)
-'@ | Out-File $testFile1
-
-            Update-CMakeFile $testFile1 'sentry-native' 'v0.9.2'
+'@
 
-            $content = Get-Content $testFile1 -Raw
-            $content | Should -Match 'GIT_TAG v0.9.2'
-            $content | Should -Not -Match 'v0.9.1'
-            # Verify structure preservation
-            $content | Should -Match 'include\(FetchContent\)'
-            $content | Should -Match 'FetchContent_MakeAvailable'
-            $content | Should -Match 'GIT_REPOSITORY https://github.com/getsentry/sentry-native'
-            $content | Should -Match 'GIT_SHALLOW FALSE'
-
-            # Test 2: Hash to newer hash update
-            $testFile2 = "$tempDir/hash-update.cmake"
-            @'
+            # Template for hash-based CMake file
+            $script:hashTemplate = @'
 include(FetchContent)
 
 FetchContent_Declare(
@@ -226,21 +212,10 @@ FetchContent_Declare(
 )
 
 FetchContent_MakeAvailable(sentry-native)
-'@ | Out-File $testFile2
-
-            # Update to a newer tag that will be converted to hash (0.11.0 is known to exist)
-            Update-CMakeFile $testFile2 'sentry-native' '0.11.0'
-
-            $content = Get-Content $testFile2 -Raw
-            # Should have new hash with tag comment
-            $content | Should -Match 'GIT_TAG [a-f0-9]{40} # 0.11.0'
-            # Should not have old hash or old comment
-            $content | Should -Not -Match 'a64d5bd8ee130f2cda196b6fa7d9b65bfa6d32e2'
-            $content | Should -Not -Match '# 0.9.1'
+'@
 
-            # Test 3: Complex formatting
-            $testFile3 = "$tempDir/complex-format.cmake"
-            @'
+            # Template for complex formatting
+            $script:complexTemplate = @'
 include(FetchContent)
 
 FetchContent_Declare(
@@ -256,29 +231,67 @@ FetchContent_Declare(
 )
 
 FetchContent_MakeAvailable(sentry-native)
-'@ | Out-File $testFile3
+'@
+        }
 
-            Update-CMakeFile $testFile3 'sentry-native' 'v0.9.2'
+        BeforeEach {
+            # Create fresh test files for each test
+            $script:basicTestFile = "$tempDir/basic-test.cmake"
+            $script:hashTestFile = "$tempDir/hash-test.cmake"
+            $script:complexTestFile = "$tempDir/complex-test.cmake"
+        }
 
-            $content = Get-Content $testFile3 -Raw
-            $content | Should -Match 'GIT_TAG\s+v0.9.2'
+        It 'updates tag to tag preserving format' {
+            $basicTemplate | Out-File $basicTestFile
+
+            Update-CMakeFile $basicTestFile 'sentry-native' 'v0.9.2'
+
+            $content = Get-Content $basicTestFile -Raw
+            $content | Should -Match 'GIT_TAG v0.9.2'
             $content | Should -Not -Match 'v0.9.1'
         }
 
-        It 'handles error scenarios appropriately' {
-            $testFile = "$tempDir/error-test.cmake"
-            @'
-include(FetchContent)
+        It 'updates hash to newer hash preserving format' {
+            $hashTemplate | Out-File $hashTestFile
 
-FetchContent_Declare(
-    sentry-native
-    GIT_REPOSITORY https://github.com/getsentry/sentry-native
-    GIT_TAG v0.9.1
-)
-'@ | Out-File $testFile
+            # Update to a newer tag that will be converted to hash (0.11.0 is known to exist)
+            Update-CMakeFile $hashTestFile 'sentry-native' '0.11.0'
+
+            $content = Get-Content $hashTestFile -Raw
+            # Should have new hash with tag comment
+            $content | Should -Match 'GIT_TAG [a-f0-9]{40} # 0.11.0'
+            # Should not have old hash or old comment
+            $content | Should -Not -Match 'a64d5bd8ee130f2cda196b6fa7d9b65bfa6d32e2'
+            $content | Should -Not -Match '# 0.9.1'
+        }
+
+        It 'preserves file structure and other content' {
+            $basicTemplate | Out-File $basicTestFile
+
+            Update-CMakeFile $basicTestFile 'sentry-native' 'v0.9.2'
+
+            $content = Get-Content $basicTestFile -Raw
+            $content | Should -Match 'include\(FetchContent\)'
+            $content | Should -Match 'FetchContent_MakeAvailable'
+            $content | Should -Match 'GIT_REPOSITORY https://github.com/getsentry/sentry-native'
+            $content | Should -Match 'GIT_SHALLOW FALSE'
+        }
+
+        It 'handles complex formatting correctly' {
+            $complexTemplate | Out-File $complexTestFile
+
+            Update-CMakeFile $complexTestFile 'sentry-native' 'v0.9.2'
+
+            $content = Get-Content $complexTestFile -Raw
+            $content | Should -Match 'GIT_TAG\s+v0.9.2'
+            $content | Should -Not -Match 'v0.9.1'
+        }
+
+        It 'throws on failed regex match' {
+            $basicTemplate | Out-File $basicTestFile
 
             # Try to update a dependency that doesn't exist
-            { Update-CMakeFile $testFile 'nonexistent-dep' 'v1.0.0' } | Should -Throw "*FetchContent_Declare for 'nonexistent-dep' not found*"
+            { Update-CMakeFile $basicTestFile 'nonexistent-dep' 'v1.0.0' } | Should -Throw "*FetchContent_Declare for 'nonexistent-dep' not found*"
         }
 
         # Note: Hash update tests require network access for git ls-remote