refactor: streamline conditional checks and improve code readability in update-dependency.ps1

Author: vaind

updater/scripts/update-dependency.ps1

@@ -39,31 +39,24 @@ if ($Path -match '^(.+\.cmake)(#(.+))?$') {
     $isCMakeFile = $false
 }
 
-if (-not (Test-Path $Path ))
-{
+if (-not (Test-Path $Path )) {
     throw "Dependency $Path doesn't exit";
 }
 
 # If it's a directory, we consider it a submodule dependendency. Otherwise, it must a properties-style file or a script.
 $isSubmodule = (Test-Path $Path -PathType Container)
 
-function SetOutput([string] $name, $value)
-{
-    if (Test-Path env:GITHUB_OUTPUT)
-    {
+function SetOutput([string] $name, $value) {
+    if (Test-Path env:GITHUB_OUTPUT) {
         "$name=$value" | Tee-Object $env:GITHUB_OUTPUT -Append
-    }
-    else
-    {
+    } else {
         "$name=$value"
     }
 }
 
-if (-not $isSubmodule)
-{
+if (-not $isSubmodule) {
     $isScript = $Path -match '\.(ps1|sh)$'
-    function DependencyConfig ([Parameter(Mandatory = $true)][string] $action, [string] $value = $null)
-    {
+    function DependencyConfig ([Parameter(Mandatory = $true)][string] $action, [string] $value = $null) {
         if ($isCMakeFile) {
             # CMake file handling
             switch ($action) {
@@ -84,64 +77,48 @@ if (-not $isSubmodule)
                 'set-version' {
                     Update-CMakeFile $Path $cmakeDep $value
                 }
-                Default {
+                default {
                     throw "Unknown action $action"
                 }
             }
-        }
-        elseif ($isScript)
-        {
-            if (Get-Command 'chmod' -ErrorAction SilentlyContinue)
-            {
+        } elseif ($isScript) {
+            if (Get-Command 'chmod' -ErrorAction SilentlyContinue) {
                 chmod +x $Path
-                if ($LastExitCode -ne 0)
-                {
+                if ($LastExitCode -ne 0) {
                     throw 'chmod failed';
                 }
             }
-            try
-            {
+            try {
                 $result = & $Path $action $value
                 $failed = -not $?
-            }
-            catch
-            {
+            } catch {
                 $result = $_
                 $failed = $true
             }
-            if ($failed)
-            {
+            if ($failed) {
                 throw "Script execution failed: $Path $action $value | output: $result"
             }
             return $result
-        }
-        else
-        {
-            switch ($action)
-            {
-                'get-version'
-                {
+        } else {
+            switch ($action) {
+                'get-version' {
                     return (Get-Content $Path -Raw | ConvertFrom-StringData).version
                 }
-                'get-repo'
-                {
+                'get-repo' {
                     return (Get-Content $Path -Raw | ConvertFrom-StringData).repo
                 }
-                'set-version'
-                {
+                'set-version' {
                     $content = Get-Content $Path
                     $content = $content -replace '^(?<prop>version *= *).*$', "`${prop}$value"
                     $content | Out-File $Path
 
                     $readVersion = (Get-Content $Path -Raw | ConvertFrom-StringData).version
 
-                    if ("$readVersion" -ne "$value")
-                    {
+                    if ("$readVersion" -ne "$value") {
                         throw "Update failed - read-after-write yielded '$readVersion' instead of expected '$value'"
                     }
                 }
-                Default
-                {
+                default {
                     throw "Unknown action $action"
                 }
             }
@@ -152,27 +129,20 @@ if (-not $isSubmodule)
     . "$PSScriptRoot/cmake-functions.ps1"
 }
 
-if ("$Tag" -eq '')
-{
-    if ($isSubmodule)
-    {
+if ("$Tag" -eq '') {
+    if ($isSubmodule) {
         git submodule update --init --no-fetch --single-branch $Path
         Push-Location $Path
-        try
-        {
+        try {
             $originalTag = $(git describe --tags)
             git fetch --tags
             [string[]]$tags = $(git tag --list)
             $url = $(git remote get-url origin)
             $mainBranch = $(git remote show origin | Select-String 'HEAD branch: (.*)').Matches[0].Groups[1].Value
-        }
-        finally
-        {
+        } finally {
             Pop-Location
         }
-    }
-    else
-    {
+    } else {
         $originalTag = DependencyConfig 'get-version'
         $url = DependencyConfig 'get-repo'
 
@@ -181,8 +151,7 @@ if ("$Tag" -eq '')
         $tags = $tags | ForEach-Object { ($_ -split '\s+')[1] -replace '^refs/tags/', '' }
 
         $headRef = ($(git ls-remote $url HEAD) -split '\s+')[0]
-        if ("$headRef" -eq '')
-        {
+        if ("$headRef" -eq '') {
             throw "Couldn't determine repository head (no ref returned by ls-remote HEAD"
         }
         $mainBranch = (git ls-remote --heads $url | Where-Object { $_.StartsWith($headRef) }) -replace '.*\srefs/heads/', ''
@@ -191,64 +160,42 @@ if ("$Tag" -eq '')
     $url = $url -replace '\.git$', ''
 
     # Filter by GitHub release titles if pattern is provided
-    if ("$GhTitlePattern" -ne '')
-    {
+    if ("$GhTitlePattern" -ne '') {
         Write-Host "Filtering tags by GitHub release title pattern '$GhTitlePattern'"
 
         # Parse GitHub repo owner/name from URL
-        if ($url -notmatch 'github\.com[:/]([^/]+)/([^/]+?)(?:\.git)?$')
-        {
+        if ($url -notmatch 'github\.com[:/]([^/]+)/([^/]+?)(?:\.git)?$') {
             throw "Could not parse GitHub owner/repo from URL: $url"
         }
 
         $owner, $repo = $Matches[1], $Matches[2]
 
-        try
-        {
-            # Fetch releases from GitHub API
-            $releases = @(gh api "repos/$owner/$repo/releases" --jq '.[] | {tag_name: .tag_name, name: .name}' | ConvertFrom-Json)
-
-            # Find tags that have matching release titles
-            $validTags = @{}
-            foreach ($release in $releases)
-            {
-                if ($release.name -match $GhTitlePattern)
-                {
-                    $validTags[$release.tag_name] = $true
-                }
-            }
-
-            # Filter tags to only include those with matching release titles
-            $originalTagCount = $tags.Length
-            $tags = @($tags | Where-Object { $validTags.ContainsKey($_) })
-            Write-Host "GitHub release title filtering: $originalTagCount -> $($tags.Count) tags"
+        # Fetch releases from GitHub API
+        $releases = @(gh api "repos/$owner/$repo/releases" --jq '.[] | {tag_name: .tag_name, name: .name}' | ConvertFrom-Json)
 
-            if ($tags.Count -eq 0)
-            {
-                throw "Found no tags with GitHub releases matching title pattern '$GhTitlePattern'"
+        # Find tags that have matching release titles
+        $validTags = @{}
+        foreach ($release in $releases) {
+            if ($release.name -match $GhTitlePattern) {
+                $validTags[$release.tag_name] = $true
             }
         }
-        catch
-        {
-            if ($_.Exception.Message -like "*Found no tags with GitHub releases matching title pattern*")
-            {
-                throw
-            }
-            throw "Failed to fetch GitHub releases for $owner/$repo`: $($_.Exception.Message)"
-        }
+
+        # Filter tags to only include those with matching release titles
+        $originalTagCount = $tags.Length
+        $tags = @($tags | Where-Object { $validTags.ContainsKey($_) })
+        Write-Host "GitHub release title filtering: $originalTagCount -> $($tags.Count) tags"
     }
 
-    if ("$Pattern" -eq '')
-    {
+    if ("$Pattern" -eq '') {
         # Use a default pattern that excludes pre-releases
         $Pattern = '^v?([0-9.]+)$'
     }
 
     Write-Host "Filtering tags with pattern '$Pattern'"
     $tags = $tags -match $Pattern
 
-    if ($tags.Length -le 0)
-    {
+    if ($tags.Length -le 0) {
         throw "Found no tags matching pattern '$Pattern'"
     }
 
@@ -257,14 +204,11 @@ if ("$Tag" -eq '')
     Write-Host "Sorted tags: $tags"
     $latestTag = $tags[-1]
 
-    if (("$originalTag" -ne '') -and ("$latestTag" -ne '') -and ("$latestTag" -ne "$originalTag"))
-    {
-        do
-        {
+    if (("$originalTag" -ne '') -and ("$latestTag" -ne '') -and ("$latestTag" -ne "$originalTag")) {
+        do {
             # It's possible that the dependency was updated to a pre-release version manually in which case we don't want to
             # roll back, even though it's not the latest version matching the configured pattern.
-            if ((GetComparableVersion $originalTag) -ge (GetComparableVersion $latestTag))
-            {
+            if ((GetComparableVersion $originalTag) -ge (GetComparableVersion $latestTag)) {
                 Write-Host "SemVer represented by the original tag '$originalTag' is newer than the latest tag '$latestTag'. Skipping update."
                 $latestTag = $originalTag
                 break
@@ -274,8 +218,7 @@ if ("$Tag" -eq '')
             $refs = $(git ls-remote --tags $url)
             $refOriginal = (($refs -match "refs/tags/$originalTag" ) -split '[ \t]') | Select-Object -First 1
             $refLatest = (($refs -match "refs/tags/$latestTag" ) -split '[ \t]') | Select-Object -First 1
-            if ($refOriginal -eq $refLatest)
-            {
+            if ($refOriginal -eq $refLatest) {
                 Write-Host "Latest tag '$latestTag' points to the same commit as the original tag '$originalTag'. Skipping update."
                 $latestTag = $originalTag
                 break
@@ -291,23 +234,19 @@ if ("$Tag" -eq '')
     SetOutput 'url' $url
     SetOutput 'mainBranch' $mainBranch
 
-    if ("$originalTag" -eq "$latestTag")
-    {
+    if ("$originalTag" -eq "$latestTag") {
         return
     }
 
     $Tag = $latestTag
 }
 
-if ($isSubmodule)
-{
+if ($isSubmodule) {
     Write-Host "Updating submodule $Path to $Tag"
     Push-Location $Path
     git checkout $Tag
     Pop-Location
-}
-else
-{
+} else {
     Write-Host "Updating 'version' in $Path to $Tag"
     DependencyConfig 'set-version' $tag
 }