fix: Clippy lints (#1)

Author: jan-auer

client/src/lib.rs

@@ -42,12 +42,14 @@ pub struct StorageId {
     id: String,
 }
 impl StorageId {
-    pub fn from_str(id: &str) -> Self {
-        Self { id: id.into() }
+    pub fn new(id: String) -> Self {
+        Self { id }
     }
 }
 
-static MOCK_STORAGE: LazyLock<Mutex<HashMap<(&'static str, StorageScope, StorageId), Arc<[u8]>>>> =
+type StorageKey = (&'static str, StorageScope, StorageId);
+
+static MOCK_STORAGE: LazyLock<Mutex<HashMap<StorageKey, Arc<[u8]>>>> =
     LazyLock::new(Default::default);
 
 pub struct StorageClient {

service/src/datamodel.rs

@@ -1,3 +1,5 @@
+#![allow(unused)]
+
 pub enum Compression {
     None,
     Zstd,

stresstest/src/raw_seaweed.rs

@@ -48,8 +48,7 @@ impl SeaweedClient {
             if payload.len == 0 {
                 return Poll::Ready(None);
             }
-            let mut read_buf = Vec::with_capacity(1024 * 1024);
-            read_buf.resize(1024 * 1024, 0);
+            let mut read_buf = vec![0; 1024 * 1024];
             let read_len = payload.read(&mut read_buf).unwrap();
             read_buf.truncate(read_len);
 
@@ -97,7 +96,7 @@ impl SeaweedClient {
         let mut expected_payload = Vec::new();
         payload.read_to_end(&mut expected_payload).unwrap();
 
-        if file_contents != &expected_payload {
+        if file_contents != expected_payload {
             panic!("readback mismatch?");
         }
     }

stresstest/src/workload.rs

@@ -54,7 +54,7 @@ impl WorkloadBuilder {
 
         let size_distribution = LogNormal::new(mu, sigma).unwrap();
         let action_distribution =
-            WeightedIndex::new(&[self.write_weight, self.read_weight, self.delete_weight]).unwrap();
+            WeightedIndex::new([self.write_weight, self.read_weight, self.delete_weight]).unwrap();
 
         Workload {
             name: self.name,