Skip to content

Commit 97d5e91

Browse files
authored
fix(stresstest): Disable hickory (#248)
As soon as hickory is enabled, hostname overrides declared in the hosts file are ignored. This is unexpected with default settings used by reqwest. To unblock sandbox tests, we disable hickory now, but need to follow up with a proper fix.
1 parent c4dc5fe commit 97d5e91

File tree

3 files changed

+7
-20
lines changed

3 files changed

+7
-20
lines changed

Cargo.lock

Lines changed: 2 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

stresstest/Cargo.toml

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ publish = false
1212
[dependencies]
1313
anyhow = { workspace = true }
1414
argh = "0.1.13"
15-
bytes = { workspace = true }
1615
bytesize = { version = "2.0.1", features = ["serde"] }
1716
futures = { workspace = true }
1817
futures-util = { workspace = true }
@@ -22,21 +21,9 @@ mimalloc = { workspace = true }
2221
objectstore-client = { workspace = true }
2322
rand = { workspace = true, features = ["small_rng"] }
2423
rand_distr = "0.5.1"
25-
reqwest = { workspace = true, features = [
26-
"hickory-dns",
27-
"json",
28-
"stream",
29-
"multipart",
30-
] }
3124
serde = { workspace = true }
32-
serde_json = { workspace = true }
3325
serde_yaml = "0.9.34-deprecated"
3426
sketches-ddsketch = "0.3.0"
35-
tokio = { workspace = true, features = [
36-
"rt",
37-
"rt-multi-thread",
38-
"sync",
39-
"macros",
40-
] }
27+
tokio = { workspace = true, features = ["rt-multi-thread", "sync", "macros"] }
4128
tokio-util = { workspace = true }
4229
yansi = "1.0.1"

stresstest/src/http.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,10 @@ impl HttpRemote {
1818
/// Creates a new `HttpRemote` instance with the given remote URL and a default client.
1919
pub fn new(remote: &str) -> Self {
2020
Self {
21-
client: Client::new(remote).unwrap(),
21+
client: Client::builder(remote)
22+
.configure_reqwest(|r| r.no_hickory_dns())
23+
.build()
24+
.unwrap(),
2225
}
2326
}
2427

0 commit comments

Comments
 (0)