simplify

Author: lcian

objectstore-server/src/auth/service.rs

@@ -1,7 +1,6 @@
 use objectstore_service::id::{ObjectContext, ObjectId};
 use objectstore_service::{
-    BatchInsertResult, DeleteResult, GetResult, InsertResult, InsertStream, PayloadStream,
-    StorageService,
+    DeleteResult, GetResult, InsertResult, InsertStream, PayloadStream, StorageService,
 };
 use objectstore_types::{Metadata, Permission};
 
@@ -76,14 +75,4 @@ impl AuthAwareService {
         self.assert_authorized(Permission::ObjectDelete, id.context())?;
         self.service.delete_object(id).await
     }
-
-    /// Auth-aware wrapper around [`StorageService::insert_objects`].
-    pub async fn insert_objects(
-        &self,
-        context: ObjectContext,
-        inserts: InsertStream,
-    ) -> BatchInsertResult {
-        self.assert_authorized(Permission::ObjectWrite, &context)?;
-        self.service.insert_objects(context, inserts).await
-    }
 }

objectstore-service/src/lib.rs

@@ -10,13 +10,11 @@ mod backend;
 pub mod id;
 
 use std::path::Path;
-use std::pin::Pin;
 use std::sync::Arc;
 use std::sync::atomic::{AtomicU64, Ordering};
 use std::time::Instant;
 
 use bytes::{Bytes, BytesMut};
-use futures_util::Stream;
 use futures_util::{StreamExt, TryStreamExt, stream::BoxStream};
 use objectstore_types::Metadata;
 
@@ -95,12 +93,6 @@ pub type InsertResult = anyhow::Result<ObjectId>;
 /// Result type for delete operations.
 pub type DeleteResult = anyhow::Result<()>;
 
-/// Type alias to represent a stream of insert operations.
-pub type InsertStream =
-    Pin<Box<dyn Stream<Item = Result<(Metadata, Bytes), anyhow::Error>> + Send>>;
-/// Result type for batch insert operations.
-pub type BatchInsertResult = anyhow::Result<Vec<InsertResult>>;
-
 impl StorageService {
     /// Creates a new `StorageService` with the specified configuration.
     pub async fn new(
@@ -289,15 +281,6 @@ impl StorageService {
 
         Ok(())
     }
-
-    /// TODO
-    pub async fn insert_objects(
-        &self,
-        _context: ObjectContext,
-        _inserts: InsertStream,
-    ) -> BatchInsertResult {
-        todo!();
-    }
 }
 
 fn is_tombstoned(result: &Option<(Metadata, PayloadStream)>) -> bool {