feedback

Author: joshuarli

bin/backfill-core-metadata

@@ -5,6 +5,7 @@ import argparse
 import hashlib
 import json
 import os.path
+import shutil
 import subprocess
 import tempfile
 import urllib.parse
@@ -42,12 +43,12 @@ def main(argv: Sequence[str] | None = None) -> int:
                 continue
 
             url = f"{args.pypi_url}/wheels/{basename}"
-            fp = f"{tmpdir}/{basename}"
+            fn = f"{tmpdir}/{basename}"
 
-            with urllib.request.urlopen(url) as resp, open(fp, "wb") as f:
-                f.write(resp.read())
+            with urllib.request.urlopen(url) as resp, open(fn, "wb") as f:
+                shutil.copyfileobj(resp, f)
 
-            metadata_bytes = _get_metadata_bytes(fp)
+            metadata_bytes = _get_metadata_bytes(fn)
             metadata_sha256 = hashlib.sha256(metadata_bytes).hexdigest()
 
             with open(f"{tmpdir}/metadata/{basename}.metadata", "wb") as f:

make_index.py

@@ -33,8 +33,7 @@ def _get_metadata_bytes(filename: str) -> bytes:
             if name.endswith(".dist-info/METADATA") and name.count("/") == 1
         )
         with zipf.open(metadata) as f:
-            metadata_bytes = f.read()
-            return metadata_bytes
+            return f.read()
 
 
 def _make_info(filename: str) -> dict[str, Any]:
@@ -92,7 +91,6 @@ def main(argv: Sequence[str] | None = None) -> int:
         for filename in filenames
     ):
         basename = os.path.basename(filename)
-
         if basename in on_pypi:
             raise AssertionError(f"{basename}: already on pypi?")
         elif basename in seen: