Skip to content

Conversation

@joshuarli
Copy link
Member

@joshuarli joshuarli commented Jun 30, 2025

@joshuarli joshuarli changed the title . feat: core metadata support Jun 30, 2025
@joshuarli joshuarli changed the title feat: core metadata support feat: core metadata support and backfill Jun 30, 2025
@joshuarli
Copy link
Member Author

@asottile-sentry what do you think so far, especially wrt backfilling? i just plan on reverting --rebuild after it runs

69f4a1d
https://github.com/getsentry/pypi/actions/runs/15984744173/job/45086927050
no upload-artifact: build didn't do anything but i added something to packages.ini - do you know why?

Copy link
Contributor

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the backfill should maybe be a separate script that we delete afterwards?

@asottile-sentry
Copy link
Contributor

@asottile-sentry what do you think so far, especially wrt backfilling? i just plan on reverting --rebuild after it runs

69f4a1d https://github.com/getsentry/pypi/actions/runs/15984744173/job/45086927050 no upload-artifact: build didn't do anything but i added something to packages.ini - do you know why?

looks like it did to me?

@joshuarli
Copy link
Member Author

thanks for your feedback - think i have proper core metadata support now, idk what i was thinking yesterday - see output here https://github.com/getsentry/pypi/actions/runs/16009745935/job/45164718186?pr=1508#step:7:61

I think the backfill should maybe be a separate script that we delete afterwards?

as it stands now we can just run python3 -um make_index --rebuild --pypi-url https://pypi.devinfra.sentry.io --dest index one time - unless you want me to make a separate script? there's not much extra code with args.rebuild so...

@joshuarli joshuarli requested a review from asottile-sentry July 1, 2025 20:47
@joshuarli joshuarli marked this pull request as ready for review July 1, 2025 20:47
@joshuarli joshuarli requested review from asottile-sentry and removed request for asottile-sentry July 15, 2025 20:10
Copy link
Contributor

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this repo uses merge workflow please clean up your commits before merging

@joshuarli joshuarli force-pushed the feat-core-metadata branch from 2006dd6 to 447a2fd Compare July 24, 2025 17:09
@joshuarli joshuarli merged commit 11ee138 into main Jul 24, 2025
17 checks passed
@joshuarli joshuarli deleted the feat-core-metadata branch July 24, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants