Skip to content

Conversation

@sentry-release-bot
Copy link
Contributor

No description provided.

@sentry-release-bot sentry-release-bot bot enabled auto-merge August 14, 2025 18:41
@sentry-release-bot sentry-release-bot bot merged commit b257bfe into main Aug 14, 2025
15 checks passed
@sentry-release-bot sentry-release-bot bot deleted the craft-release-2ac309396af2dc2a1707cd7d37c6085f22d0c6d3 branch August 14, 2025 18:42
Comment on lines +2013 to 2014
[sentry-forked-djangorestframework-stubs==3.16.2.post1]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: Adding a package to packages.ini won't make it installable. The build process always runs incrementally and won't regenerate the index for this change, causing installation failures.
  • Description: The build process, specifically the make_index.py script, always runs in an incremental mode using the --previous-package-list-json flag. This incremental mode does not add new package entries from packages.ini to the index unless a new wheel is built. However, the build.py script will not build a new wheel for the added package sentry-forked-djangorestframework-stubs==3.16.2.post1 because it determines the package is already satisfied by existing wheels. Consequently, the new package entry will not be indexed, causing any downstream installation attempts for this specific version to fail with a package not found error.

  • Suggested fix: The build workflow needs a mechanism to trigger a full regeneration of the PyPI index when packages.ini is modified. This could involve conditionally removing the --previous-package-list-json flag from the make_index.py call to force a full rebuild when changes to packages.ini are detected.
    severity: 0.85, confidence: 0.95

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao. absolute garbage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants