Skip to content

Conversation

@lcian
Copy link
Member

@lcian lcian commented Sep 12, 2025

This adds https://pypi.org/project/sentry-conventions/ which contains semantic conventions for spans, logs, etc. used across Sentry.

@lcian lcian enabled auto-merge September 12, 2025 15:48
@asottile-sentry
Copy link
Contributor

if this is an internal package you shouldn't need to do this. it should be configured with the craft target to release to sentry pypi

@lcian lcian disabled auto-merge September 12, 2025 15:53
@lcian
Copy link
Member Author

lcian commented Sep 12, 2025

Got it, thanks @asottile-sentry
I thought we would still need to do this.

@lcian lcian closed this Sep 12, 2025
@asottile-sentry
Copy link
Contributor

Got it, thanks @asottile-sentry I thought we would still need to do this.

is there some doc somewhere that says that? I'm confused how we got here 😆

@lcian
Copy link
Member Author

lcian commented Sep 12, 2025

Nope, just a misunderstanding on my side.

When using the release registry, we need to first publish the package, then add it to the registry, and only then we can add the config to .craft.yml so that it updates the registry automatically with every release.
At least that's how we've been doing it so far in sentry-java, see for example https://github.com/getsentry/sentry-java/blob/23d6b12b2b55fc91a376800ee6c792943e027e23/.craft.yml#L22

So I thought we would have to follow the same process for PyPI.
Of course PyPI and the release registry are two completely separate things, but for some reason I expected they would work in the same way 😅

@lcian lcian deleted the lcian/add-conventions branch September 12, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants