Skip to content

Commit 734f6a0

Browse files
loewenheimDav1dde
andauthored
feat(spanv2): Implement PII scrubbing (#5168)
This ports the PII scrubbing logic from logs to spans V2 pretty much unchanged. I ported over most tests as well, the one exception being `test_ourlog_extraction_default_pii_scrubbing_does_not_scrub_default_attributes` because I couldn't make it work—there's some difference in the pipelines between logs and spans that makes this nontrivial. I also added some tests for the scrubbing of span links (since they can have attributes of their own), everything is working as expected there. Closes #5131. Closes RELAY-155. --------- Co-authored-by: David Herberth <[email protected]>
1 parent 203fdaf commit 734f6a0

File tree

64 files changed

+3279
-2671
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+3279
-2671
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
- Maps `unknown_error` span status to `internal_error`. ([#5202](https://github.com/getsentry/relay/pull/5202))
2121
- Add `otp` and `two[-_]factor` to default scrubbing rules. ([#5250](https://github.com/getsentry/relay/pull/5250))
2222
- Add event merging logic for Playstation crashes. ([#5228](https://github.com/getsentry/relay/pull/5228))
23+
- Implement PII scrubbing for V2 spans. ([#5168](https://github.com/getsentry/relay/pull/5168))
2324

2425
**Bug Fixes**:
2526

relay-config/src/config.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -617,7 +617,7 @@ pub struct Limits {
617617
pub max_profile_size: ByteSize,
618618
/// The maximum payload size for a trace metric.
619619
pub max_trace_metric_size: ByteSize,
620-
/// The maximum payload size for a span.
620+
/// The maximum payload size for a log.
621621
pub max_log_size: ByteSize,
622622
/// The maximum payload size for a span.
623623
pub max_span_size: ByteSize,

0 commit comments

Comments
 (0)