fix(playstation): keep dump instead of discarding it (#4758)

Previously we removed the dump, however we want to keep the dump as an
attachment as it is interesting to the users.

Author: tobias-wilfert

relay-server/src/services/processor/playstation.rs

@@ -31,7 +31,8 @@ pub fn process(
         return Ok(None);
     }
 
-    if let Some(item) = envelope.take_item_by(|item| {
+    // Get instead of take as we want to keep the dump as an attachment
+    if let Some(item) = envelope.get_item_by(|item| {
         item.ty() == &ItemType::Attachment
             && item.attachment_type() == Some(&AttachmentType::Prosperodump)
     }) {

tests/integration/test_playstation.py

@@ -139,6 +139,10 @@ def test_playstation_with_feature_flag(
     assert event_data["_metrics"]["bytes.ingested.event.minidump"] > 0
     assert event_data["_metrics"]["bytes.ingested.event.attachment"] > 0
 
+    assert len(event["attachments"]) == 3
+    attachment = event["attachments"][0]
+    assert attachment["attachment_type"] == "playstation.prosperodump"
+
 
 def test_playstation_attachment(
     mini_sentry,
@@ -219,6 +223,10 @@ def test_playstation_attachment(
     assert event_data["_metrics"]["bytes.ingested.event.minidump"] > 0
     assert event_data["_metrics"]["bytes.ingested.event.attachment"] > 0
 
+    assert len(event["attachments"]) == 3
+    attachment = event["attachments"][0]
+    assert attachment["attachment_type"] == "playstation.prosperodump"
+
 
 def test_playstation_attachment_no_feature_flag(
     mini_sentry,