Skip to content

Commit b97e972

Browse files
authored
build(makefile): Dont setup venv on every format and lint (#5289)
The setup runs everytime you run `make format-python` which runs `devenv sync` and rebuilds `uv` which removes `sentry-relay` from the `venv`. So after running `make format-python` integration tests don't work again. Ideally the setup is skipped if it is not necessary (what used to happen) but somehow the triggers don't work anymore and I couldn't figure out why. So for now you need to setup the venv first, then run the actions (like what happens on commit).
1 parent 58277dc commit b97e972

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

Makefile

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ lint-rust: setup-git ## run lint on Rust code using clippy
104104
cargo +stable clippy --workspace --all-targets --all-features --no-deps -- -D warnings
105105
.PHONY: lint-rust
106106

107-
lint-python: setup-venv-light ## run lint on Python code using flake8
107+
lint-python: ## run lint on Python code using flake8
108108
.venv/bin/pre-commit run flake8 -a
109109
.venv/bin/pre-commit run mypy -a
110110
.PHONY: lint-python
@@ -125,7 +125,7 @@ format-rust: ## format the Rust code
125125
cargo +stable fmt --all
126126
.PHONY: format-rust
127127

128-
format-python: setup-venv-light ## format the Python code
128+
format-python: ## format the Python code
129129
.venv/bin/pre-commit run black -a
130130
.PHONY: format-python
131131

@@ -146,10 +146,6 @@ setup-venv: uv.lock ## create a Python virtual environment with development requ
146146
RELAY_DEBUG=1 uv pip install -v -e py
147147
.PHONY: setup-venv
148148

149-
setup-venv-light: uv.lock
150-
devenv sync
151-
.PHONY: setup-venv-light
152-
153149
clean-target-dir:
154150
if [ "$$(du -s target/ | cut -f 1)" -gt 4000000 ]; then \
155151
rm -rf target/; \

0 commit comments

Comments
 (0)