feat(relay): Remove static mode (#5108)

This needs to be coordinated with changes in Sentry that make managed
mode available to everyone and an updating of the docs telling people
managed mode is now available.

Sentry PRs: getsentry/sentry#98696 &
getsentry/sentry#98688
Docs PR: getsentry/sentry-docs#14787

Ref: https://linear.app/getsentry/issue/INGEST-545/update-relay

---------

Co-authored-by: Joris Bayer <[email protected]>

Author: tobias-wilfert

CHANGELOG.md

@@ -5,7 +5,7 @@
 **Breaking Changes**:
 
 - Removes support for the deprecated and early alpha only otel log item type. ([#5082](https://github.com/getsentry/relay/pull/5082))
-- Only check for local project configs in static mode. ([#5057](https://github.com/getsentry/relay/pull/5057))
+- Remove static mode. ([#5108](https://github.com/getsentry/relay/pull/5108))
 
 **Features**:
 

relay-config/src/config.rs

@@ -324,7 +324,7 @@ impl RelayInfo {
 }
 
 /// The operation mode of a relay.
-#[derive(Clone, Copy, Debug, Eq, PartialEq, Deserialize, Serialize)]
+#[derive(Clone, Copy, Debug, Eq, PartialEq, Serialize)]
 #[serde(rename_all = "camelCase")]
 pub enum RelayMode {
     /// This relay acts as a proxy for all requests and events.
@@ -334,12 +334,6 @@ pub enum RelayMode {
     /// accepted unless overridden on the file system.
     Proxy,
 
-    /// This relay is configured statically in the file system.
-    ///
-    /// Events are only accepted for projects configured statically in the file system. All other
-    /// events are rejected. If configured, PII stripping is also performed on those events.
-    Static,
-
     /// Project configurations are managed by the upstream.
     ///
     /// Project configurations are always fetched from the upstream, unless they are statically
@@ -348,11 +342,30 @@ pub enum RelayMode {
     Managed,
 }
 
+impl<'de> Deserialize<'de> for RelayMode {
+    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
+    where
+        D: Deserializer<'de>,
+    {
+        let s = String::deserialize(deserializer)?;
+        match s.as_str() {
+            "proxy" => Ok(RelayMode::Proxy),
+            "managed" => Ok(RelayMode::Managed),
+            "static" => Err(serde::de::Error::custom(
+                "Relay mode 'static' has been removed. Please use 'managed' or 'proxy' instead.",
+            )),
+            other => Err(serde::de::Error::unknown_variant(
+                other,
+                &["proxy", "managed"],
+            )),
+        }
+    }
+}
+
 impl fmt::Display for RelayMode {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
         match self {
             RelayMode::Proxy => write!(f, "proxy"),
-            RelayMode::Static => write!(f, "static"),
             RelayMode::Managed => write!(f, "managed"),
         }
     }
@@ -402,10 +415,7 @@ pub struct ParseRelayModeError;
 
 impl fmt::Display for ParseRelayModeError {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        write!(
-            f,
-            "Relay mode must be one of: managed, static, proxy, capture"
-        )
+        write!(f, "Relay mode must be one of: managed or proxy")
     }
 }
 
@@ -417,7 +427,6 @@ impl FromStr for RelayMode {
     fn from_str(s: &str) -> Result<Self, Self::Err> {
         match s {
             "proxy" => Ok(RelayMode::Proxy),
-            "static" => Ok(RelayMode::Static),
             "managed" => Ok(RelayMode::Managed),
             _ => Err(ParseRelayModeError),
         }

relay-server/src/processing/mod.rs

@@ -92,7 +92,7 @@ impl Context<'_> {
         use relay_config::RelayMode::*;
 
         match self.config.relay_mode() {
-            Proxy | Static => false,
+            Proxy => false,
             Managed => !self.project_info.has_feature(feature),
         }
     }

relay-server/src/services/processor.rs

@@ -827,7 +827,7 @@ fn event_type(event: &Annotated<Event>) -> Option<EventType> {
 /// If the project config did not come from the upstream, we keep the items.
 fn should_filter(config: &Config, project_info: &ProjectInfo, feature: Feature) -> bool {
     match config.relay_mode() {
-        RelayMode::Proxy | RelayMode::Static => false,
+        RelayMode::Proxy => false,
         RelayMode::Managed => !project_info.has_feature(feature),
     }
 }

relay-server/src/services/projects/project/mod.rs

@@ -105,8 +105,7 @@ pub struct ParsedProjectState {
     pub disabled: bool,
     /// Project info.
     ///
-    /// This contains no information when `disabled` is `true`, except for
-    /// public keys in static project configs (see [`crate::services::projects::source::local`]).
+    /// This contains no information when `disabled` is `true`.
     #[serde(flatten)]
     pub info: ProjectInfo,
 }
@@ -119,8 +118,7 @@ pub struct LimitedParsedProjectState {
     pub disabled: bool,
     /// Limited project info for external Relays.
     ///
-    /// This contains no information when `disabled` is `true`, except for
-    /// public keys in static project configs (see [`crate::services::projects::source::local`]).
+    /// This contains no information when `disabled` is `true`.
     #[serde(with = "LimitedProjectInfo")]
     #[serde(flatten)]
     pub info: ProjectInfo,