Skip to content

If metrics extraction fails, dynamic sampling should also failΒ #5403

@jjbayer

Description

@jjbayer

Follow-up to #5379: We currently perform some checks on the metrics extraction config before running dynamic sampling. However, it is still possible to run dynamic sampling and then fail metrics extraction, because metrics extraction has stricter requirements on the config (e.g. generic metrics extraction config).

Instead of checking the config twice, do all the checks in run_dynamic_sampling and pass the resulting config to extract_metrics as a struct. This way, the two checks cannot go out of sync.

Metadata

Metadata

Assignees

No one assigned

    Labels

    fillerRequires little effort to resolve. Ready to be picked up anytime.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions