Skip to content

test(projectconfigs): Remove flaky test #5587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjbayer merged 1 commit into from
Jan 28, 2026
+0 −49
Merged

test(projectconfigs): Remove flaky test #5587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 0 additions & 49 deletions tests/integration/test_projectconfigs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,55 +271,6 @@ def assert_clear_test_failures():
assert mini_sentry.captured_envelopes.empty()


def test_cached_project_config(mini_sentry, relay):
mini_sentry.project_config_ignore_revision = True

project_key = 42
relay_config = {
"cache": {"project_expiry": 2, "project_grace_period": 5, "miss_expiry": 2}
}
relay = relay(mini_sentry, relay_config)
mini_sentry.add_full_project_config(project_key)
public_key = mini_sentry.get_dsn_public_key(project_key)

# Once the event is sent the project state is requested and cached.
relay.send_event(project_key)
event = mini_sentry.get_captured_envelope().get_event()
assert event["logentry"] == {"formatted": "Hello, World!"}
# send a second event
relay.send_event(project_key)
event = mini_sentry.get_captured_envelope().get_event()
assert event["logentry"] == {"formatted": "Hello, World!"}

body = {"publicKeys": [public_key]}
packed, signature = SecretKey.parse(relay.secret_key).pack(body)
data, _ = get_response(relay, packed, signature)
assert data["configs"][public_key]["projectId"] == project_key
assert not data["configs"][public_key]["disabled"]

# Introduce unparsable config.
config = mini_sentry.project_configs[project_key]
config["slug"] = 99 # ERROR: Number not allowed

# Give it a bit time for update to go through.
time.sleep(1)
data, _ = get_response(relay, packed, signature)

assert data["configs"][public_key]["projectId"] == project_key
assert not data["configs"][public_key]["disabled"]

# Wait till grace period expires as well and we should start buffering the events now.
time.sleep(5)
try:
relay.send_event(project_key)
time.sleep(0.5)
assert {str(e) for _, e in mini_sentry.current_test_failures()} == {
f"Relay sent us event: error fetching project state {public_key}: invalid type: integer `99`, expected a string",
}
finally:
mini_sentry.clear_test_failures()


def test_get_global_config(mini_sentry, relay):
project_key = 42
relay_config = {
Expand Down
Loading