feat(compose): Add ability to use custom images for any Sentry service (#602)

This change allows one to override any Sentry service image, mostly for testing purposes. It also removes the SENTRY_VERSION variable as docker-compose makes it very hard to cascade default values for these. Next step is to have integration tests in getsentry/snuba and getsentry/relay (and possibly for getsentry/symbolicator) for getsentry/onpremise using this PR.

Also related: #596.

Author: BYK

.env

@@ -1,3 +1,6 @@
 COMPOSE_PROJECT_NAME=sentry_onpremise
 SENTRY_EVENT_RETENTION_DAYS=90
-SENTRY_VERSION=10.0.0
+SENTRY_IMAGE=getsentry/sentry:10.0.0
+SNUBA_IMAGE=getsentry/snuba:10.0.0
+RELAY_IMAGE=getsentry/relay:10.0.0
+SYMBOLICATOR_IMAGE=getsentry/symbolicator:8ac8f400fb7416c6c46fad856cdba2bc70c27c6c

docker-compose.yml

@@ -7,7 +7,6 @@ x-sentry-defaults: &sentry_defaults
     context: ./sentry
     args:
       - SENTRY_IMAGE
-      - SENTRY_VERSION
   image: sentry-onpremise-local
   depends_on:
     - redis
@@ -30,7 +29,7 @@ x-snuba-defaults: &snuba_defaults
     - redis
     - clickhouse
     - kafka
-  image: 'getsentry/snuba:$SENTRY_VERSION'
+  image: '$SNUBA_IMAGE'
   environment:
     SNUBA_SETTINGS: docker
     CLICKHOUSE_HOST: clickhouse
@@ -126,11 +125,11 @@ services:
     build:
       context: ./cron
       args:
-        BASE_IMAGE: 'getsentry/snuba:$SENTRY_VERSION'
+        BASE_IMAGE: '$SNUBA_IMAGE'
     command: '"*/5 * * * * gosu snuba snuba cleanup --dry-run False"'
   symbolicator:
     << : *restart_policy
-    image: 'getsentry/symbolicator:8ac8f400fb7416c6c46fad856cdba2bc70c27c6c'
+    image: '$SYMBOLICATOR_IMAGE'
     volumes:
       - 'sentry-symbolicator:/data'
     command: run
@@ -140,7 +139,7 @@ services:
     build:
       context: ./cron
       args:
-        BASE_IMAGE: 'getsentry/symbolicator:8ac8f400fb7416c6c46fad856cdba2bc70c27c6c'
+        BASE_IMAGE: '$SYMBOLICATOR_IMAGE'
     command: '"55 23 * * * gosu symbolicator symbolicator cleanup"'
     volumes:
       - 'sentry-symbolicator:/data'

sentry/Dockerfile

@@ -1,6 +1,5 @@
-ARG SENTRY_VERSION=latest
 ARG SENTRY_IMAGE
-FROM ${SENTRY_IMAGE:-getsentry/sentry:$SENTRY_VERSION}
+FROM ${SENTRY_IMAGE}
 
 WORKDIR /usr/src/sentry