Skip to content

Commit 52f1c90

Browse files
aldy505BYK
andauthored
Apply suggestions from code review
Co-authored-by: Burak Yigit Kaya <[email protected]>
1 parent dae4436 commit 52f1c90

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

docker-compose.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ x-sentry-defaults: &sentry_defaults
7272
SENTRY_STATSD_ADDR: "${STATSD_ADDR:-}"
7373
volumes:
7474
- "sentry-data:/data"
75-
- "sentry-vroom:/var/vroom/sentry-profiles"
7675
- "./sentry:/etc/sentry"
7776
- "./geoip:/geoip:ro"
7877
- "./certificates:/usr/local/share/ca-certificates:ro"

install/bootstrap-s3-profiles.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
echo "${_group}Bootstrapping seaweedfs (profiles)..."
22

33
# The purpose of this file is to have both `sentry`-based containers and `vroom` use the same bucket for profiling.
4-
# Currently, we have a `sentry-vroom` volume which stores the profiling data. However, since version 25.10.0,
4+
# On pre-25.10.0, we have a `sentry-vroom` volume which stores the profiling data however, since this version,
55
# the behavior changed, and `vroomrs` now ingests profiles directly. Both services must share the same bucket,
66
# but at the time of this writing, it's not possible because the `sentry-vroom` volume has ownership set to `vroom:vroom`.
77
# This prevents the `sentry`-based containers from performing read/write operations on that volume.
@@ -23,7 +23,7 @@ if [[ $(echo "$bucket_list" | tail -1 | awk '{print $3}') != 's3://profiles' ]];
2323
if ! grep -q "filestore.profiles-backend" $SENTRY_CONFIG_YML; then
2424
if [[ -z "${APPLY_AUTOMATIC_CONFIG_UPDATES:-}" ]]; then
2525
echo
26-
echo "We are migrating the Profiles data directory from the 'sentry-vroom' volume to S3."
26+
echo "We are migrating the Profiles data directory from the 'sentry-vroom' volume to SeaweedFS."
2727
echo "This migration will ensure profiles ingestion works correctly with the new 'vroomrs'"
2828
echo "and allows both 'sentry' and 'vroom' to transition smoothly."
2929
echo "To complete this, your sentry/config.yml file needs to be modified."

0 commit comments

Comments
 (0)