Remove symbolicator external volume (#3992)

* Remove symbolicator volume creation command

* Remove symbolicator volume

* Create sentry-symbolicator on docker compose up

* Pass volume name to remove_command

* Remove sentry-symbolicator from unit test

Author: aminvakil

_unit-test/create-docker-volumes-test.sh

@@ -14,8 +14,7 @@ sentry-data
 sentry-kafka
 sentry-postgres
 sentry-redis
-sentry-seaweedfs
-sentry-symbolicator"
+sentry-seaweedfs"
 
 before=$(get_volumes)
 

docker-compose.yml

@@ -820,10 +820,11 @@ volumes:
     external: true
   sentry-clickhouse:
     external: true
-  sentry-symbolicator:
-    external: true
   sentry-seaweedfs:
     external: true
+  # The volume stores cached version of debug symbols, source maps etc. Upon
+  # removal symbolicator will re-download them.
+  sentry-symbolicator:
   # This volume stores JS SDK assets and the data inside this volume should
   # be cleaned periodically on upgrades.
   sentry-nginx-www:

install/create-docker-volumes.sh

@@ -16,7 +16,6 @@ echo "Created $(create_volume sentry-data)."
 echo "Created $(create_volume sentry-kafka)."
 echo "Created $(create_volume sentry-postgres)."
 echo "Created $(create_volume sentry-redis)."
-echo "Created $(create_volume sentry-symbolicator)."
 echo "Created $(create_volume sentry-seaweedfs)."
 
 echo "${_endgroup}"

install/turn-things-off.sh

@@ -17,4 +17,11 @@ else
   fi
 fi
 
+remove_volume() {
+  remove_command="$CONTAINER_ENGINE volume remove -f"
+  $remove_command $1
+}
+
+echo "Removed $(remove_volume sentry-symbolicator)."
+
 echo "${_endgroup}"