Skip to content

Commit e333dbd

Browse files
committed
fix(install): Only use .env for fallbacks
This fixes a serious bug in install.sh where it ignored externaly set env variable values such as `SENTRY_IMAGE` in favor of the ones defined in `.env`, essentially making all our e2e tests usless.
1 parent de2b610 commit e333dbd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

install.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
#!/usr/bin/env bash
22
set -e
33

4-
# With a tip o' the hat to https://unix.stackexchange.com/a/79077
5-
set -a && . ./.env && set +a
4+
# Read .env for default values with a tip o' the hat to https://stackoverflow.com/a/59831605/90297
5+
t=$(mktemp) && export -p > "$t" && set -a && . ./.env && set +a && . "$t" && rm "$t" && unset t
66

77
dc="docker-compose --no-ansi"
88
dcr="$dc run --rm"

0 commit comments

Comments
 (0)