Skip to content

Commit fcf0d35

Browse files
authored
Add --skip-sse42-requirements to install.sh and enable SKIP_SSE42_REQUIREMENTS override (#1790)
Not all environments are KVM, and not all virtualized CPUs show SSE4.2 support even if they do support it. This adds an escape hatch if you know what you are doing.
1 parent 2403619 commit fcf0d35

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

install/check-minimum-requirements.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,9 @@ fi
5050

5151
#SSE4.2 required by Clickhouse (https://clickhouse.yandex/docs/en/operations/requirements/)
5252
# On KVM, cpuinfo could falsely not report SSE 4.2 support, so skip the check. https://github.com/ClickHouse/ClickHouse/issues/20#issuecomment-226849297
53+
# This may also happen on other virtualization software such as on VMWare ESXi hosts.
5354
IS_KVM=$(docker run --rm busybox grep -c 'Common KVM processor' /proc/cpuinfo || :)
54-
if [[ "$IS_KVM" -eq 0 && "$DOCKER_ARCH" = "x86_64" ]]; then
55+
if [[ ! "$SKIP_SSE42_REQUIREMENTS" -eq 1 && "$IS_KVM" -eq 0 && "$DOCKER_ARCH" = "x86_64" ]]; then
5556
SUPPORTS_SSE42=$(docker run --rm busybox grep -c sse4_2 /proc/cpuinfo || :)
5657
if [[ "$SUPPORTS_SSE42" -eq 0 ]]; then
5758
echo "FAIL: The CPU your machine is running on does not support the SSE 4.2 instruction set, which is required for one of the services Sentry uses (Clickhouse). See https://github.com/getsentry/self-hosted/issues/340 for more info."

install/parse-cli.sh

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,11 @@ Options:
1717
--skip-commit-check Skip the check for the latest commit when on the master
1818
branch of a \`self-hosted\` Git working copy.
1919
--skip-user-creation Skip the initial user creation prompt (ideal for non-
20-
interactive installs).
20+
interactive installs).
21+
--skip-sse42-requirements
22+
Skip checking that your environment meets the
23+
requirements to run Sentry. Only do this if you know
24+
what you are doing.
2125
--report-self-hosted-issues
2226
Report error and performance data about your self-hosted
2327
instance upstream to Sentry. See sentry.io/privacy for
@@ -41,6 +45,7 @@ SKIP_USER_CREATION="${SKIP_USER_CREATION:-}"
4145
MINIMIZE_DOWNTIME="${MINIMIZE_DOWNTIME:-}"
4246
SKIP_COMMIT_CHECK="${SKIP_COMMIT_CHECK:-}"
4347
REPORT_SELF_HOSTED_ISSUES="${REPORT_SELF_HOSTED_ISSUES:-}"
48+
SKIP_SSE42_REQUIREMENTS="${SKIP_SSE42_REQUIREMENTS:-}"
4449

4550
while (($#)); do
4651
case "$1" in
@@ -61,6 +66,7 @@ while (($#)); do
6166
--skip-commit-check) SKIP_COMMIT_CHECK=1 ;;
6267
--report-self-hosted-issues) REPORT_SELF_HOSTED_ISSUES=1 ;;
6368
--no-report-self-hosted-issues) REPORT_SELF_HOSTED_ISSUES=0 ;;
69+
--skip-sse42-requirements) SKIP_SSE42_REQUIREMENTS=1 ;;
6470
--) ;;
6571
*)
6672
echo "Unexpected argument: $1. Use --help for usage information."

0 commit comments

Comments
 (0)