From 7972c589b5f54c0bed24aaaf37e5355feecd06ba Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Klemens=20B=C3=B6swirth?=
 <23529132+kodebach@users.noreply.github.com>
Date: Fri, 14 Nov 2025 22:02:37 +0000
Subject: [PATCH] fix: ensure seaweedfs lifecycle policy is set correctly

---
 install/bootstrap-s3-nodestore.sh | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/install/bootstrap-s3-nodestore.sh b/install/bootstrap-s3-nodestore.sh
index c2cf91669f5..98d934b4461 100644
--- a/install/bootstrap-s3-nodestore.sh
+++ b/install/bootstrap-s3-nodestore.sh
@@ -62,7 +62,11 @@ if [[ $(echo "$bucket_list" | tail -1 | awk '{print $3}') != 's3://nodestore' ]]
 
   $dc exec seaweedfs mkdir -p /data/idx/
   $s3cmd --access_key=sentry --secret_key=sentry --no-ssl --region=us-east-1 --host=localhost:8333 --host-bucket='localhost:8333/%(bucket)' mb s3://nodestore
+else
+  echo "Node store already exists, skipping creation..."
+fi
 
+if [[ -z "${APPLY_AUTOMATIC_CONFIG_UPDATES:-}" || "$APPLY_AUTOMATIC_CONFIG_UPDATES" == 1 ]]; then
   # XXX(aldy505): Should we refactor this?
   lifecycle_policy=$(
     cat <<EOF
@@ -79,13 +83,11 @@ if [[ $(echo "$bucket_list" | tail -1 | awk '{print $3}') != 's3://nodestore' ]]
 </LifecycleConfiguration>
 EOF
   )
-  $dc exec seaweedfs sh -c "printf '%s' '$lifecycle_policy' > /tmp/nodestore-lifecycle-policy.xml"
-  $s3cmd --access_key=sentry --secret_key=sentry --no-ssl --region=us-east-1 --host=localhost:8333 --host-bucket='localhost:8333/%(bucket)' setlifecycle /tmp/nodestore-lifecycle-policy.xml s3://nodestore
 
   echo "Making sure the bucket lifecycle policy is all set up correctly..."
+  $dc exec seaweedfs sh -c "printf '%s' '$lifecycle_policy' > /tmp/nodestore-lifecycle-policy.xml"
+  $s3cmd --access_key=sentry --secret_key=sentry --no-ssl --region=us-east-1 --host=localhost:8333 --host-bucket='localhost:8333/%(bucket)' setlifecycle /tmp/nodestore-lifecycle-policy.xml s3://nodestore
   $s3cmd --access_key=sentry --secret_key=sentry --no-ssl --region=us-east-1 --host=localhost:8333 --host-bucket='localhost:8333/%(bucket)' getlifecycle s3://nodestore
-else
-  echo "Node store already exists, skipping..."
 fi
 
 echo "${_endgroup}"